Add option to dump debug info to jit-diffs #166
Conversation
Off by default. Enable via --debuginfo. Info is dumped after the method (like unwind and eh) and will show up as file diffs.
|
@BruceForstall PTAL |
There was a problem hiding this comment.
One bug.
Making it opt-in seems ok, but unlikely anyone will use it. We should make it the default it if behaves well with diffing (doesn't create unnecessary diffs with small changes). The reason GCInfo is not default is our only way to dump GC info now requires annotating instructions with code offsets, which means adding or removing an instruction causes diffs in all subsequent lines. If we changed our GC info dump to be interleaved with instructions (e.g., +rax +V01 -rcx), then we could (and should!) make GC info dumping the default as well.
src/jit-dasm/jit-dasm.cs
Outdated
| @@ -362,6 +366,7 @@ private class DisasmEngine | |||
| _assemblyInfoList = assemblyInfoList; | |||
|
|
|||
| this.doGCDump = config.DumpGCInfo; | |||
| this.doDebugDump = config.DumpGCInfo; | |||
|
Easiest thing is to make it off by default in the sub-tools but on by default in jit-diffs. There can be cascading diffs like you mention for GC. But hopefully not too painful? We could do the same kind of interleaved display for IL offsets and variable scopes that you suggest we do for GC info. Seems like it might be worth a try... |
|
Ok, well if there might be cascading diffs, I would leave it as-is, and have a different work item (or items) to eliminate those, that would then change the defaults here. |
|
Opened dotnet/coreclr#19850 for the intermingled approach. |
Off by default. Enable via --debuginfo.
Info is dumped after the method (like unwind and eh) and will show up
as file diffs.