Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Onboarding onto Arcade #219

Closed
wants to merge 4 commits into from
Closed

Onboarding onto Arcade #219

wants to merge 4 commits into from

Conversation

echesakov
Copy link
Contributor

No description provided.

@echesakov echesakov force-pushed the OnboardingOntoArcade branch from 5ae9a5b to b4ac620 Compare October 30, 2019 19:57
@echesakov echesakov requested a review from sbomer November 1, 2019 18:47
sbomer
sbomer reviewed Nov 1, 2019
View reviewed changes
eng/Versions.props
<SystemIOFileSystemPackageVersion>4.3.0</SystemIOFileSystemPackageVersion>
<SystemNetPrimitivesPackageVersion>4.3.0</SystemNetPrimitivesPackageVersion>
<runtimenativeSystemPackageVersion>4.3.0</runtimenativeSystemPackageVersion>
<SystemSecurityPrincipalPackageVersion>4.3.0</SystemSecurityPrincipalPackageVersion>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using Version instead of PackageVersion as a suffix - not that it really matters, but will be more consistent with dotnet/coreclr#27606 for example.

sbomer
sbomer approved these changes Nov 1, 2019
View reviewed changes
Copy link
Member

@sbomer sbomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'd make sure that the updated projects continue to work with the bootstrapping scripts if you haven't already.

@BruceForstall BruceForstall mentioned this pull request Feb 20, 2020
Merged
@BruceForstall BruceForstall mentioned this pull request Mar 18, 2020
Closed
@BruceForstall BruceForstall mentioned this pull request Sep 9, 2020
Merged
@kunalspathak
Copy link
Member

@echesakovMSFT - Are you planning to pursue this further?

@echesakov
Copy link
Contributor Author

@echesakovMSFT - Are you planning to pursue this further?

@kunalspathak Yes, but not earlier than I finish moving coredistools to a separate repo.

@echesakov echesakov mentioned this pull request Sep 17, 2020
Closed
29 tasks
@echesakov echesakov mentioned this pull request Oct 20, 2020
Closed
Base automatically changed from master to main March 10, 2021 13:05
@echesakov
Copy link
Contributor Author

Not going to work on this in near future.

@echesakov echesakov closed this Jun 3, 2021
@BruceForstall BruceForstall mentioned this pull request Nov 9, 2021
Closed
@echesakov echesakov mentioned this pull request Nov 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbomer sbomer sbomer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@echesakov @kunalspathak @sbomer