Fix jit-format for Windows #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dotnet/jit-contrib |
sandreenko
approved these changes
Nov 20, 2020
jashook
approved these changes
Nov 20, 2020
I am not sure. May be after I merge this PR, I can revert dotnet/runtime#40035 and dotnet/runtime#40517 and trigger a CI run? |
@sandreenko - Sent out dotnet/runtime#45015 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jit-format was broken on Windows after dotnet/runtime#43651 was merged. Fixed it to use
Windowsinstead ofWindows_NT. This will break for people who still haven't merged the changes forWindows_NT->Windows, but it is OK to break them because eventually usingWindowsis the right thing.