Correctly handle assembly qualified names in generic parameters #1546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marek-safar
reviewed
Oct 7, 2020
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
mateoatr
approved these changes
Oct 7, 2020
marek-safar
approved these changes
Oct 7, 2020
We always assumed that the generic parameters would come from the same assembly as the generic type itself. Adds a new test to validate the scenario.
vitek-karas
force-pushed
the
HandleAssemblyQualifiedNamesInGenerics
branch
from
927c0c1 to
c7a62ed
Compare
mateoatr
pushed a commit
to mateoatr/linker
that referenced
this pull request
Nov 13, 2020
…et#1546) We always assumed that the generic parameters would come from the same assembly as the generic type itself. Adds a new test to validate the scenario.
agocke
pushed a commit
to dotnet/runtime
that referenced
this pull request
Nov 16, 2022
…et/linker#1546) We always assumed that the generic parameters would come from the same assembly as the generic type itself. Adds a new test to validate the scenario. Commit migrated from dotnet/linker@82ae21e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We always assumed that the generic parameters would come from the same assembly as the generic type itself.
Adds a new test to validate the scenario.
Fixes the primary issue in #1536
The other parts to make that scenario work fully are tracked by different issues.