Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for generic attributes #2980

Merged
merged 2 commits into from
Aug 23, 2022
Merged

Conversation

sbomer
Copy link
Member

@sbomer sbomer commented Aug 17, 2022

Depends on dotnet/cecil#36.
Fixes #2963.

@sbomer sbomer changed the title Add generic attribute tests Add support for generic attributes Aug 23, 2022
Copy link
Member

@vitek-karas vitek-karas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - maybe create an issue to add tests which do some simple validation of data flow stuff on the generic instantiations of attributes.
I'm not worried about linker, but analyzer and AoT might have problems.

@sbomer sbomer merged commit e2dba52 into dotnet:main Aug 23, 2022
sbomer added a commit to sbomer/linker that referenced this pull request Aug 23, 2022
* Add generic attribute tests
* Update cecil
sbomer added a commit that referenced this pull request Aug 23, 2022
* Add generic attribute tests
* Update cecil
agocke pushed a commit to dotnet/runtime that referenced this pull request Nov 16, 2022
* Add generic attribute tests
* Update cecil

Commit migrated from dotnet/linker@e2dba52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[wasm] ILLinker crash System.NotImplementedException: Var in System.Reflection.Metadata tests
2 participants