Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prediction engine for time series. #1618
Prediction engine for time series. #1618
Changes from all commits
a87d836
227adb6
7a7fe64
8fc8307
cae6f89
8381205
ccaabd4
11b42e4
7d21d78
878e87d
745ff1c
6adadee
31b91e7
75ec0b7
0efc46d
a870984
b7db101
5cb319a
c66940e
237aab4
e8d10e5
54593d3
7bf4c39
dbf3a20
a6e6d27
ffcc045
a28d461
3247537
4c27aa1
1a660e4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is confusing. You now can access the inner transformers in 3 ways: via
foreach
(as anIEnumerable
), via the internal fieldTransformers
and viaITransformerAccessor.Transformers
. Let's reduce it to one. Maybe make in anIEnumerable
of pairs, if you need access toscopes
#ResolvedThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or you could make
Transformers
andScopes
public andIReadOnlyList
sIn reply to: 236007659 [](ancestors = 236007659)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I created this interface so that I can access transformers and scope from an ITransfomer reference because casting ITransfomer to TransformerChain is messy.
In reply to: 236007746 [](ancestors = 236007746,236007659)