Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement MSML_RelaxTestNaming suppressor for VSTHRD200 #4803

Merged
merged 3 commits into from
Feb 14, 2020

Conversation

sharwell
Copy link
Member

@sharwell sharwell commented Feb 6, 2020

Allow asynchronous test methods to omit the 'Async' suffix.

@sharwell sharwell marked this pull request as ready for review February 13, 2020 15:34
@sharwell sharwell requested a review from a team as a code owner February 13, 2020 15:34
@sharwell
Copy link
Member Author

@harishsk for reviews

@sharwell
Copy link
Member Author

Or @justinormont

@harishsk
Copy link
Contributor

Is this PR to allow tests that have await calls within them to not be forced to have an Async suffix for the function name?

Also, can you please resolve the merge conflicts?

@sharwell
Copy link
Member Author

Is this PR to allow tests that have await calls within them to not be forced to have an Async suffix for the function name?

Yes, that is correct.

@sharwell sharwell merged commit 0b4b15b into dotnet:master Feb 14, 2020
@sharwell sharwell deleted the relax-test-names branch February 14, 2020 14:24
@ghost ghost locked as resolved and limited conversation to collaborators Mar 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants