Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XGBoost Trainer interface (WIP) #6383

Closed
wants to merge 4 commits into from
Closed

Conversation

rgesteve
Copy link
Contributor

We are excited to review your PR.

So we can do the best job, please check:

  • There's a descriptive title that will make sense to other developers some time from now.
  • There's associated issues. All PR's should have issue(s) associated - unless a trivial self-evident change such as fixing a typo. You can use the format Fixes #nnnn in your description to cause GitHub to automatically close the issue(s) when your PR is merged.
  • Your change description explains what the change does, why you chose your approach, and anything else that reviewers should know. (see below)
  • You have included any necessary tests in the same PR. (forthcoming)

Replaces PR #6345 in using a Trainer rather than a Transformer interface for the XGBoost integration. Currently, only a regression trainer is enabled, but a binary classifier is in progress. To run, the user is expected to have a copy of the xgboost library appropriate to their system and available (maybe through a mechanism like updates to their PATH or LD_LIBRARY_PATH environment variables). We are working in ways to reduce the burden of this requirement.

Please expect some edits to this PR, including the addition of unit tests.

@codecov
Copy link

codecov bot commented Nov 16, 2022

Codecov Report

Merging #6383 (5fc1440) into main (ff21cc5) will decrease coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6383      +/-   ##
==========================================
- Coverage   68.57%   68.57%   -0.01%     
==========================================
  Files        1171     1171              
  Lines      247197   247197              
  Branches    25799    25799              
==========================================
- Hits       169519   169515       -4     
- Misses      70954    70958       +4     
  Partials     6724     6724              
Flag Coverage Δ
Debug 68.57% <ø> (-0.01%) ⬇️
production 62.96% <ø> (-0.01%) ⬇️
test 88.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/Microsoft.ML.FastTree/Utils/ThreadTaskManager.cs 79.48% <0.00%> (-20.52%) ⬇️
src/Microsoft.ML.Maml/MAML.cs 25.88% <0.00%> (-1.02%) ⬇️
src/Microsoft.ML.LightGbm/LightGbmTrainerBase.cs 79.50% <0.00%> (-0.28%) ⬇️
...soft.ML.Data/DataLoadSave/Text/TextLoaderCursor.cs 90.25% <0.00%> (+0.47%) ⬆️
src/Microsoft.ML.FastTree/Training/StepSearch.cs 62.37% <0.00%> (+4.95%) ⬆️

@rgesteve
Copy link
Contributor Author

rgesteve commented May 8, 2023

Replaced in favor of #6662 , which updates to the latest XGBoost version available in miniconda and makes use of .net 7+ features.

@rgesteve rgesteve closed this May 8, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Jun 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant