Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing arm python brew overwite #7058

Merged
merged 4 commits into from
Mar 12, 2024
Merged

Conversation

michaelgsharp
Copy link
Member

@michaelgsharp michaelgsharp commented Mar 11, 2024

Fixes #7056

Testing quick fix for M1 build break.

Copy link
Member

@ericstj ericstj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it works looks good .

Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.82%. Comparing base (f6ddd9b) to head (fa9b041).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7058   +/-   ##
=======================================
  Coverage   68.82%   68.82%           
=======================================
  Files        1255     1255           
  Lines      250358   250358           
  Branches    25550    25550           
=======================================
+ Hits       172307   172311    +4     
+ Misses      71440    71437    -3     
+ Partials     6611     6610    -1     
Flag Coverage Δ
Debug 68.82% <ø> (+<0.01%) ⬆️
production 63.26% <ø> (+<0.01%) ⬆️
test 88.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

@michaelgsharp
Copy link
Member Author

Merging on red since known test issue.

@michaelgsharp michaelgsharp merged commit 59973fc into dotnet:main Mar 12, 2024
22 of 25 checks passed
@michaelgsharp michaelgsharp deleted the m1-fix branch March 12, 2024 16:52
ericstj added a commit to ericstj/machinelearning that referenced this pull request Mar 13, 2024
* testing arm python brew overwite

* more m1 testing

* Install python@3.12 before libomp

* Update official build libomp install command

---------

Co-authored-by: Eric StJohn <ericstj@microsoft.com>
ericstj added a commit that referenced this pull request Mar 14, 2024
* Change official build to use 1ES templates (#7048)

With any luck this doesn't break our builds (official build tests have been done from a branch)

* Updated for https://dev.azure.com/dnceng/7ea9116e-9fac-403d-b258-b31fcf1bb293/_build?definitionId=1110 by using baselines generated in https://dev.azure.com/dnceng/7ea9116e-9fac-403d-b258-b31fcf1bb293/_build/results?buildId=2396001 (#7051)

Co-authored-by: MerlinBot <merlinbotcore@microsoft.com>

* testing arm python brew overwite (#7058)

* testing arm python brew overwite

* more m1 testing

* Install python@3.12 before libomp

* Update official build libomp install command

---------

Co-authored-by: Eric StJohn <ericstj@microsoft.com>

---------

Co-authored-by: Jo Shields <directhex@apebox.org>
Co-authored-by: MerlinBot <merlinbotcore@microsoft.com>
Co-authored-by: Michael Sharp <51342856+michaelgsharp@users.noreply.github.com>
@github-actions github-actions bot locked and limited conversation to collaborators Apr 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mac builds failing during Install MacOS ARM build dependencies step
2 participants