-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
testing arm python brew overwite #7058
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericstj
approved these changes
Mar 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it works looks good .
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7058 +/- ##
=======================================
Coverage 68.82% 68.82%
=======================================
Files 1255 1255
Lines 250358 250358
Branches 25550 25550
=======================================
+ Hits 172307 172311 +4
+ Misses 71440 71437 -3
+ Partials 6611 6610 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
This was referenced Mar 12, 2024
Open
Merging on red since known test issue. |
ericstj
added a commit
to ericstj/machinelearning
that referenced
this pull request
Mar 13, 2024
* testing arm python brew overwite * more m1 testing * Install python@3.12 before libomp * Update official build libomp install command --------- Co-authored-by: Eric StJohn <ericstj@microsoft.com>
ericstj
added a commit
that referenced
this pull request
Mar 14, 2024
* Change official build to use 1ES templates (#7048) With any luck this doesn't break our builds (official build tests have been done from a branch) * Updated for https://dev.azure.com/dnceng/7ea9116e-9fac-403d-b258-b31fcf1bb293/_build?definitionId=1110 by using baselines generated in https://dev.azure.com/dnceng/7ea9116e-9fac-403d-b258-b31fcf1bb293/_build/results?buildId=2396001 (#7051) Co-authored-by: MerlinBot <merlinbotcore@microsoft.com> * testing arm python brew overwite (#7058) * testing arm python brew overwite * more m1 testing * Install python@3.12 before libomp * Update official build libomp install command --------- Co-authored-by: Eric StJohn <ericstj@microsoft.com> --------- Co-authored-by: Jo Shields <directhex@apebox.org> Co-authored-by: MerlinBot <merlinbotcore@microsoft.com> Co-authored-by: Michael Sharp <51342856+michaelgsharp@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7056
Testing quick fix for M1 build break.