Skip to content

Commit

Permalink
[iOS/Catalyst] Correctly call DidFinishNavigation in NavigationDelega…
Browse files Browse the repository at this point in the history
…te (#20725)

* Invoke ProcessNavigatedAsync for MauiWKWebView

* Add underlying API back

* Revert sandbox changes

* Use FireAndForget
  • Loading branch information
drasticactions authored and rmarinho committed Feb 22, 2024
1 parent a1eab3e commit 8b45ad7
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/Core/src/Platform/iOS/MauiWKWebView.cs
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ public override void MovedToWindow()
_movedToWindow?.Invoke(this, EventArgs.Empty);
}

[Export("webView:didFinishNavigation:")]
[Obsolete("Use MauiWebViewNavigationDelegate.DidFinishNavigation instead.")]
public async void DidFinishNavigation(WKWebView webView, WKNavigation navigation)
{
var url = CurrentUrl;
Expand Down
6 changes: 5 additions & 1 deletion src/Core/src/Platform/iOS/MauiWebViewNavigationDelegate.cs
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,11 @@ public void DidFinishNavigation(WKWebView webView, WKNavigation navigation)

virtualView.Navigated(_lastEvent, url, WebNavigationResult.Success);

handler.PlatformView?.UpdateCanGoBackForward(virtualView);
// ProcessNavigatedAsync calls UpdateCanGoBackForward
if (handler is WebViewHandler webViewHandler)
webViewHandler.ProcessNavigatedAsync(url).FireAndForget();
else
handler.PlatformView?.UpdateCanGoBackForward(virtualView);
}

[Export("webView:didFailNavigation:withError:")]
Expand Down

0 comments on commit 8b45ad7

Please sign in to comment.