Assigning "{x:Type ImageButton}" instead of "ImageButton" to the TargetType property of a Trigger in an ImageButton style breaks build

[MauiUIui]

Description

Almost all in the title. So an ImageButton doesn't allow {x:Type ImageButton} to be assigned as a value to the TargetType property in a Trigger of its style. Doing so yields the famous "Object reference not set to an instance of an object." error which prevents the build from completing. It doesn't matter where the trigger is defined (Default Style in Styles.xaml, in the control itself, in the resources of a containing element...)

Steps to Reproduce

1. Create a MAUI app.
2. Create an ImageButton
3. Give it a style in which a trigger is defined and set the TargetType property of that trigger "{x:Type ImageButton}".
4. Build fails

Link to public reproduction project repository

No response

Version with bug

8.0.0-rc.2.9373

Is this a regression from previous behavior?

Not sure, did not test other versions

Last version that worked well

Unknown/Other

Affected platforms

Android, Windows, I was not able test on other platforms

Affected platform versions

No response

Did you find any workaround?

Set the TargetType property to "ImageButton" instead.

Relevant log output

No response

[ghost]

Hi @MauiUIui. We have added the "s/needs-repro" label to this issue, which indicates that we require steps and sample code to reproduce the issue before we can take further action. Please try to create a minimal sample project/solution or code samples which reproduce the issue, ideally as a GitHub repo that we can clone. See more details about creating repros here: https://github.com/dotnet/maui/blob/main/.github/repro.md

This issue will be closed automatically in 7 days if we do not hear back from you by then - please feel free to re-open it if you come back to this issue after that time.

[mattleibow]

According to the docs, it should be ImageButton: https://learn.microsoft.com/en-us/dotnet/maui/fundamentals/triggers#property-triggers

Where are you getting the x:Type from?

[MauiUIui]

Where are you getting the x:Type from?

This is actually the original "form". The TargetType property is of type Type and thus should be provided a value of such type, which is originally done using the x:Type markup extension. The way it's written in the documentation you referred to is actually just a well known, well used XAML shortcut, that I usually don't use, because it dosn't always work, for example with custom types. You can read about it from its own documentation here. The link is from .NET desktop (WPF usage) but it explains it pretty well and it stayed the same over the years:

WPF supports techniques that enable specifying the value of some properties of type Type without requiring an x:Type markup extension usage. Instead, you can specify the value as a string that names the type. Examples of this are ControlTemplate.TargetType and Style.TargetType. Support for this behavior is not provided through either type converters or markup extensions. Instead, this is a deferral behavior implemented through FrameworkElementFactory.

That's why it MUST work for all controls and everywhere and it actually does with all other controls, ImageButton being the exception for now ;)

[MauiUIui]

Hi @MauiUIui. We have added the "s/needs-repro" label to this issue, which indicates that we require steps and sample code to reproduce the issue before we can take further action. Please try to create a minimal sample project/solution or code samples which reproduce the issue, ideally as a GitHub repo that we can clone. See more details about creating repros here: https://github.com/dotnet/maui/blob/main/.github/repro.md

This issue will be closed automatically in 7 days if we do not hear back from you by then - please feel free to re-open it if you come back to this issue after that time.

Dear bot and MAUI community:
It's pretty obvious (and very easy to repro), what is to do here. The fact that s/needs-repro was assigned to this bug implicates that some of you guys don't read on the job. I don't have time for this. I was trying to be y good developer by reporting a bug. Be my guest and close the issue if it makes happy, I'm not wasting anymore time on this.

[PureWeen]

@StephaneDelcroix thoughts?

[ghost]

We've added this issue to our backlog, and we will work to address it as time and resources allow. If you have any additional information or questions about this issue, please leave a comment. For additional info about issue management, please read our Triage Process.

[StephaneDelcroix]

@mattleibow and the doc were right. but I did a change to allow x:Type extension there to support what we support in runtime XAML but weren't in compiled one