[Android] Ensure custom fonts also get weight/slant #1011
Conversation
| @@ -79,27 +81,29 @@ public FontManager(IFontRegistrar fontRegistrar, ILogger<FontManager>? logger = | |||
| foreach (var folder in folders) | |||
| { | |||
| formated = $"{folder}{fontFile.FileNameWithExtension()}#{fontFile.PostScriptName}"; | |||
| var result = LoadTypefaceFromAsset(formated); | |||
| var result = LoadTypefaceFromAsset(formated, false); | |||
There was a problem hiding this comment.
Warnings at each step of the search are not needed.
|
this fixed the android tests ,but now we have 3 tests failing on iOS |
|
Yeah. I found out why... On all platforms in the universe, they can make a "regular" font bold, but iOS just can't. Just updating some tests and will push. |
| //TODO: Investigate making this Async | ||
| (bool hasFont, string? fontPath) HasFont(string font); | ||
| // TODO: this should be async as it involves copying files | ||
| string? GetFont(string font); |
There was a problem hiding this comment.
There is NO reason to have these two in a tuple - we literally always have false,null and true,notnull. I even had an extension method that converted from a tuple into a single value... I am not sure my original thought process - might have been for 100% backwards compat. But that is not worth it.
| bool CanUsePackagedNativeFonts => | ||
| #if WINDOWS | ||
| true; | ||
| #else | ||
| false; | ||
| #endif |
There was a problem hiding this comment.
This is genuinely cause for concern for all the other devs out there. Which dummy wrote this instead of using the partial classes to actually do different logic. Me. 😭
samhouts
added
legacy-area-controls
Eilon
removed
the
legacy-area-controls
samhouts
added
the
fixed-in-6.0.100-preview.5
Description of Change
Seems that custom fonts never got the weight and slant applied as well as for the "system" fonts, bold was not applied.
However, all is not perfect because of #1018