Fix renderer shim ordering when creating native renderer #1105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PureWeen
commented
May 27, 2021
| } | ||
|
|
||
| SetRenderer( |
There was a problem hiding this comment.
This is the main code change from the PR. Just moving this setter up before SetElement is called
PureWeen
force-pushed
the
fix_renderer_ordering
branch
from
cb168e4
to
76f0d77
Compare
PureWeen
force-pushed
the
fix_renderer_ordering
branch
from
76f0d77
to
b65a3a6
Compare
jsuarezruiz
approved these changes
May 28, 2021
rmarinho
approved these changes
May 28, 2021
lytico
pushed a commit
to lytico/maui
that referenced
this pull request
Jun 8, 2021
* Set Renderer before setting virtual view * - fix NET6 targets
samhouts
added
the
fixed-in-6.0.100-preview.5
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Currently we are setting the VirtualView on the renderer before setting the
Rendererbindable property on the element. When you set the VirtualView this causesOnElementChangedto fire. Any legacy renderer that is watchingOnElementChangedmight hit a NRE if it tries to access the renderer on the elementThis PR also consolidates all the RendererToHandlerShim code into a single file since the files across platforms were all 96 percent the same. Recent changes in project structure made this possible.
I added a Custom Button to our sample app that tests shimming a button. Once we have compatibility device tests then we can create more targeted tests for this behavior.