Fix renderer shim ordering when creating native renderer #1105
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Currently we are setting the VirtualView on the renderer before setting the
Renderer
bindable property on the element. When you set the VirtualView this causesOnElementChanged
to fire. Any legacy renderer that is watchingOnElementChanged
might hit a NRE if it tries to access the renderer on the elementThis PR also consolidates all the RendererToHandlerShim code into a single file since the files across platforms were all 96 percent the same. Recent changes in project structure made this possible.
I added a Custom Button to our sample app that tests shimming a button. Once we have compatibility device tests then we can create more targeted tests for this behavior.