Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement CharacterSpacing property in WinUI Editor #1153

Merged
merged 2 commits into from
Jun 9, 2021
Merged

Implement CharacterSpacing property in WinUI Editor #1153

merged 2 commits into from
Jun 9, 2021

Conversation

jsuarezruiz
Copy link
Contributor

@jsuarezruiz jsuarezruiz commented Jun 2, 2021 •
edited
Loading

Description of Change

Implement CharacterSpacing property in WinUI Editor

winui-editor-characterspacing

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)
  • Targets a single property for a single control (or intertwined few properties)
  • Adds the property to the appropriate interface
  • Avoids any changes not essential to the handler property
  • Adds the mapping to the PropertyMapper in the handler
  • Adds the mapping method to the Android, iOS, and Standard aspects of the handler
  • Implements the actual property updates (usually in extension methods in the Platform section of Core)
  • Tags ported renderer methods with [PortHandler]
  • Adds an example of the property to the sample project (MainPage)
  • Adds the property to the stub class
  • Implements basic property tests in DeviceTests

Does this PR touch anything that might affect accessibility?

  • No

@rachelkang
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

rachelkang
rachelkang approved these changes Jun 2, 2021
View reviewed changes
Copy link
Member

@rachelkang rachelkang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once all checks are passing

Merge in after #1146 gets merged in - added code in TextBoxExtensions is the same

@rmarinho rmarinho merged commit b8c5bfe into main Jun 9, 2021
@rmarinho rmarinho deleted the winui-editor-characterspacing branch June 9, 2021 09:36
@github-actions github-actions bot locked and limited conversation to collaborators Dec 26, 2023
@samhouts samhouts added the fixed-in-6.0.100-preview.5 Look for this fix in 6.0.100-preview.5! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rmarinho rmarinho rmarinho approved these changes

@rachelkang rachelkang rachelkang approved these changes

Assignees
No one assigned
Labels
area-controls-editor Editor fixed-in-6.0.100-preview.5 Look for this fix in 6.0.100-preview.5! platform/windows 🪟
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jsuarezruiz @rachelkang @rmarinho @samhouts