Ignore handler mappings that are already processed by VisualElementRenderer #1215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PureWeen
commented
Jun 8, 2021
| @@ -35,6 +35,10 @@ internal class Platform : BindableObject, IPlatformLayout, INavigation, IDisposa | |||
| var view = bindable as VisualElement; | |||
| if (view != null) | |||
| view.IsPlatformEnabled = newvalue != null; | |||
|
|
|||
| if (view.Handler == null && newvalue is IVisualElementRenderer ver) | |||
| view.Handler = new RendererToHandlerShim(ver); | |||
There was a problem hiding this comment.
We want all views to have a Handler for consistency. This way if there's a shimmed control you can still access the native elements via the Handler. This will also make it easier to implement gestures because all of the native gesture code can just be changed to retrieve the native controls via the Handler
mattleibow
approved these changes
Jun 8, 2021
jsuarezruiz
approved these changes
Jun 9, 2021
samhouts
added
the
fixed-in-6.0.100-preview.5
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
If we're shimming a renderer to a handler then we don't want properties that are already being handled by VisualElementRenderer (Scale/ScaleX/Background/etc....) to also be handled by the ViewHandler. This has the potential to cause competing implementations.