Force PageContainer to call Layout on PageViewGroup #1231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
child is a PageViewGroup. Fixes #1062
Redth
approved these changes
Jun 9, 2021
PureWeen
approved these changes
Jun 9, 2021
samhouts
added
the
fixed-in-6.0.100-preview.5
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1062
If the root page is shimmed and uses fragments to host other pages, the Layout method will never be called on a PageViewGroup that's backing the hosted page.
The old layout system relied on PlatformRenderer/Platform to force a layout that would set the width/height for the hosted page, and those values would be picked up during VisualElementTracker's OnLayout method.
Since PlatformRenderer is not in play in MauiAppCompatActivity, there's nothing to force the layout call to set those values. Normally the native layout system takes care of this for MAUI, but when the root is a shimmed legacy renderer that never happens.
This change modifies the PageContainer class to call Layout on the child control if the child control is a PageViewGroup (the backing class for MAUI pages on Android).