Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android life cycle and Shell Tweaks #1241

Merged
merged 2 commits into from
Jun 10, 2021
Merged

Android life cycle and Shell Tweaks #1241

merged 2 commits into from
Jun 10, 2021

Conversation

PureWeen
Copy link
Member

Description of Change

  • Wire up Forms.Init to get called from Maui Life Cycle events. Currently we are only calling Forms.Init from createwindow. The problem with this is that when the Activity gets created Forms.Init isn't called again so any of the bits that use the statics inside Forms start crashing
  • Copied some shell fixes from here Bump Android X xamarin/Xamarin.Forms#14101 required to make shell work
  • Fixed an issue on PageHandler so when it's disconnected it removes all of its children views

@PureWeen PureWeen requested a review from mattleibow June 10, 2021 17:30
@PureWeen PureWeen merged commit 2bb3abb into main Jun 10, 2021
@PureWeen PureWeen deleted the maui_shell_tweaks branch June 10, 2021 18:35
@dimonovdd dimonovdd mentioned this pull request Mar 17, 2023
Open
@samhouts samhouts added area-controls-shell Shell Navigation, Routes, Tabs, Flyout area-controls-pages Page types platform/android 🤖 labels Jul 11, 2023
@ghost ghost added the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label Jul 11, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 22, 2023
@Eilon Eilon removed legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor area-controls-pages Page types labels May 10, 2024
@samhouts samhouts added the fixed-in-6.0.100-preview.5 Look for this fix in 6.0.100-preview.5! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mattleibow mattleibow mattleibow approved these changes

Assignees
No one assigned
Labels
area-controls-shell Shell Navigation, Routes, Tabs, Flyout fixed-in-6.0.100-preview.5 Look for this fix in 6.0.100-preview.5! platform/android 🤖
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PureWeen @mattleibow @Eilon @samhouts