Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround Multiple Calls to Activate #14152

Merged
merged 1 commit into from
Mar 23, 2023
Merged

Workaround Multiple Calls to Activate #14152

merged 1 commit into from
Mar 23, 2023

Conversation

PureWeen
Copy link
Member

Description of Change

This works around microsoft/microsoft-ui-xaml#7343

Issues Fixed

Fixes #14142
Fixes #7894

@PureWeen PureWeen requested a review from mattleibow March 23, 2023 02:04
@@ -178,6 +199,11 @@ internal void UpdateTitleOnCustomTitleBar()

[DllImport("user32.dll", SetLastError = true)]
static extern int DestroyIcon(IntPtr hIcon);

internal void SetWindow(IWindow window)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lifecycle hooks all reached the xplat window by iterating over the static applications windows. This doesn't work very well for the tests because the tests run their own stubbed app that windows get attached to. This removes the need to resort to static scope in order to get from the platform window to the xplat window

@rmarinho rmarinho merged commit 186c644 into main Mar 23, 2023
@rmarinho rmarinho deleted the fix_14142 branch March 23, 2023 11:22
@PureWeen
Copy link
Member Author

/backport to release/8.0.1xx-preview3

@github-actions
Copy link
Contributor

Started backporting to release/8.0.1xx-preview3: https://github.com/dotnet/maui/actions/runs/4502538614

@github-actions
Copy link
Contributor

@PureWeen an error occurred while backporting to release/8.0.1xx-preview3, please check the run log for details!

Validation Failed: {"resource":"PullRequest","code":"custom","message":"No commits between release/8.0.1xx-preview3 and backport/pr-14152-to-release/8.0.1xx-preview3"}

@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2023
@samhouts samhouts added the fixed-in-8.0.0-preview.3.8149 Look for this fix in 8.0.0-preview.3.8149! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
fixed-in-8.0.0-preview.3.8149 Look for this fix in 8.0.0-preview.3.8149!
Projects
None yet
3 participants