[Android] Fix gestures in Label Spans #14410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsuarezruiz
added
platform/android 🤖
legacy-area-controls
mandel-macaque
approved these changes
Apr 5, 2023
mattleibow
reviewed
Apr 5, 2023
src/Controls/src/Core/Platform/Android/Extensions/FormattedStringExtensions.cs
Show resolved
Hide resolved
|
Can we add a device test for this ? |
Mnn, without a UI Test can validate if the PlatformView contains GestureRecognizers etc but cannot validate exactly the same scenario from the sample. |
4 tasks
mattleibow
reviewed
Apr 27, 2023
src/Controls/src/Core/Platform/Android/Extensions/FormattedStringExtensions.cs
Outdated
Show resolved
Hide resolved
mattleibow
reviewed
Apr 28, 2023
mattleibow
reviewed
Apr 29, 2023
Comment on lines
-182
to
+183
| if (View.GestureRecognizers.Count == 0) | ||
| if (View.GestureController.CompositeGestureRecognizers.Count == 0) |
mattleibow
approved these changes
May 2, 2023
samhouts
added
the
backport/suggested
|
Once we have iOS and WinUI merged then we will reassess. Ideally if we backport we would backport all platforms as one backport PR. |
|
This appears fixed on Android, but not for iOS? |
This is the iOs related PR #15544 |
Eilon
removed
the
legacy-area-controls
samhouts
added
the
fixed-in-8.0.0-preview.5.8529
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fix gestures in Label Spans on Android.
To test/validate the changes, open the .NET MAUI Gallery and navigate to the Label page. Tap the Span with the text "Click Me". If the Span changes the TextColor, is working as expected.
Issues Fixed
Fixes #4734
Fixes #8004