[Android] Fix NullReferenceException on WebAuthenticatorIntermediateActivity #15052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Hey there @Px7-941! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
|
@microsoft-github-policy-service agree |
Eilon
added
the
area-essentials
Px7-941
changed the title
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
I don't believe this is the correct or necessary fix. The reason this is getting into a state where that value is null is due to the start of the flow being from a system browser which is not supposed to call back into the intermediate activity. #15187 Should fix this. If you want to use custom tabs, you are likely missing some values in your manifest required in newer android versions. See the doc |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This pull request fixes a NullReferenceException in WebAuthenticatorIntermediateActivity.
Complements this merged pull request #12347.
Issues Fixed
Fixes #13302, #13798, #12347
Browser tests
The following browsers have been configured as the default app in the Android operating system.
For some browsers a correction of the user implementation is necessary.
LaunchMode = LaunchMode.SingleTask.https://github.com/dotnet/docs-maui/blob/main/docs/platform-integration/snippets/shared_1/Platforms/Android/WebAuthActivity.cs#L6