Fixed scroll to group item on Android + Windows #16704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 10, 2023 15:53
Fixed scrolling to a group index not working on Windows Implemented scroll to group index on Android#8718
Foda
added
area-controls-collectionview
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/rebase |
# Conflicts: # src/Controls/tests/DeviceTests/Elements/CollectionView/CollectionViewTests.cs
jsuarezruiz
reviewed
Jun 4, 2024
| await Task.Delay(100); | ||
|
|
||
| // each group has 10 items, plus the 3 headers | ||
| Assert.True(lastVisibleItemIndex == 34); |
There was a problem hiding this comment.
The test is failing on Android API_33:
|
/rebase |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
PureWeen
approved these changes
Aug 13, 2024
samhouts
added
fixed-in-net9.0-nightly
samhouts
added
fixed-in-9.0.0-rc.1.24453.9
and removed
fixed-in-net9.0-nightly
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixed scrolling to a group via
CollectionView.ScrollTo(index, groupIndex)not working on Windows or Android.Issues Fixed
Fixes #8718
Demo
The demo below shows scrolling to the group letter "N"
groupscroll_win.mp4
groupscroll_droid.mp4