-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Trimming] Fix several trimming warnings #19402
Merged
mattleibow
merged 10 commits into
dotnet:main
from
simonrozsival:fix-straightforward-trimming-warnings
Jan 16, 2024
Merged
[Trimming] Fix several trimming warnings #19402
mattleibow
merged 10 commits into
dotnet:main
from
simonrozsival:fix-straightforward-trimming-warnings
Jan 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonrozsival
added
the
area-publishing
Issues with the app packaging/publishing process (ipk/apk/msix/trimming)
label
Dec 13, 2023
vitek-karas
reviewed
Dec 13, 2023
Co-authored-by: Vitek Karas <10670590+vitek-karas@users.noreply.github.com>
…htforward-trimming-warnings
/cc @jonathanpeppers |
jonathanpeppers
approved these changes
Jan 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good now, and doesn't seem like it will change the behavior of anything. Seems ok for main
.
Can someone in @dotnet/dotnet-maui-reviewers review? Thanks!
mattleibow
approved these changes
Jan 16, 2024
19 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area-publishing
Issues with the app packaging/publishing process (ipk/apk/msix/trimming)
fixed-in-8.0.7
fixed-in-9.0.100-preview.1.9973
stale
Indicates a stale issue/pr and will be closed soon
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR fixes the following 10 trimming warnings:
Notes:
Routing.cs
other than the suppression.MetadataUpdater.IsSupported
API is not available in netstandard. I chose to keep the current behavior (IsSupported == true
)./cc @vitek-karas
Issues Fixed
Fixes several warnings mentioned in #19397