Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devices.Sensors.Location: rework argument handling in constructors #19459

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

janusw
Copy link
Contributor

@janusw janusw commented Dec 16, 2023

Description of Change

  • throw an exception if latitude is out of range
  • longitude is a cyclic variable, so we project it into a defined range
  • make all constructors behave the same way (and document the behaviour)

Issues Fixed

Fixes #19389

…ssue dotnet#19389)

* throw an exception if latitude is out of range
* longitude is a cyclic variable, so we project it into a defined range
* make all constructors behave the same way
  (and document the behaviour)
@janusw janusw requested a review from a team as a code owner December 16, 2023 10:24
@ghost ghost added the community ✨ Community Contribution label Dec 16, 2023
@ghost
Copy link

ghost commented Dec 16, 2023

Hey there @janusw! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@Eilon Eilon added the area-essentials Essentials: Device, Display, Connectivity, Secure Storage, Sensors, App Info label Dec 18, 2023
@mattleibow
Copy link
Member

/azp run MAUI-UITests-public

@mattleibow mattleibow enabled auto-merge (squash) December 19, 2023 15:57
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@hartez hartez removed their request for review January 10, 2024 20:20
@samhouts samhouts added the stale Indicates a stale issue/pr and will be closed soon label Feb 6, 2024
@rmarinho rmarinho disabled auto-merge February 12, 2024 15:44
@rmarinho rmarinho merged commit 0e61f5e into dotnet:main Feb 12, 2024
45 of 47 checks passed
@janusw janusw deleted the location_ctor_args branch February 12, 2024 16:08
@github-actions github-actions bot locked and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-essentials Essentials: Device, Display, Connectivity, Secure Storage, Sensors, App Info community ✨ Community Contribution fixed-in-8.0.10 fixed-in-9.0.0-preview.2.10247 fixed-in-9.0.0-preview.2.10293 stale Indicates a stale issue/pr and will be closed soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Location constructor silently cuts off latitude and longitude values
6 participants