Fix Clear Button size calculation #19482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattleibow
previously approved these changes
Dec 19, 2023
jsuarezruiz
previously approved these changes
Dec 19, 2023
ghost
added
the
legacy-area-controls
PureWeen
dismissed stale reviews from jsuarezruiz and mattleibow
via
0f8e47f
emaf
approved these changes
Dec 19, 2023
|
/rebase |
github-actions
bot
force-pushed
the
fix_entryclear_rtl
branch
from
0f8e47f to
d0e9e78
Compare
rmarinho
approved these changes
Dec 19, 2023
Eilon
removed
the
legacy-area-controls
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
It looks like #17543 used the incorrect value for the width of the clear button. The code accidently is using the entire view width opposed to the drawables width.
Issues Fixed
Fixes #19481