Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Shell.NavBarIsVisible property #20173

Merged
merged 2 commits into from
Aug 13, 2024
Merged

Fix Shell.NavBarIsVisible property #20173

merged 2 commits into from
Aug 13, 2024

Conversation

jsuarezruiz
Copy link
Contributor

Description of Change

Fix Shell.NavBarIsVisible property.

Issues Fixed

Fixes #18948

@jsuarezruiz jsuarezruiz added area-xaml XAML, CSS, Triggers, Behaviors area-controls-shell Shell Navigation, Routes, Tabs, Flyout labels Jan 26, 2024
@jsuarezruiz jsuarezruiz marked this pull request as ready for review February 8, 2024 14:38
@jsuarezruiz jsuarezruiz requested a review from a team as a code owner February 8, 2024 14:38
@jfversluis
Copy link
Member

/rebase

@jfversluis jfversluis requested a review from PureWeen August 7, 2024 12:55
@rmarinho rmarinho removed the request for review from StephaneDelcroix August 8, 2024 11:55
@rmarinho
Copy link
Member

rmarinho commented Aug 8, 2024

One thing I notice the other way is seems if I don t have a Title on my Shell it hides the NavBar on WinUI, but not on MacCatalyst for example .

Is this expected @PureWeen ?

@rmarinho rmarinho merged commit 210bc35 into main Aug 13, 2024
98 checks passed
@rmarinho rmarinho deleted the fix-18948 branch August 13, 2024 10:49
@samhouts samhouts added fixed-in-net9.0-nightly This may be available in a nightly release! fixed-in-net8.0-nightly This may be available in a nightly release! labels Aug 27, 2024
@samhouts samhouts added fixed-in-9.0.0-rc.1.24453.9 and removed fixed-in-net9.0-nightly This may be available in a nightly release! fixed-in-net8.0-nightly This may be available in a nightly release! labels Sep 20, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Oct 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-controls-shell Shell Navigation, Routes, Tabs, Flyout area-xaml XAML, CSS, Triggers, Behaviors fixed-in-9.0.0-rc.1.24453.9
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[regression/8.0.3] Shell.NavBarIsVisible is not working on iOS
4 participants