-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the multi-project template #20365
Conversation
ddf7c00
to
4402b94
Compare
src/Templates/src/templates/maui-multihead/MauiApp.1/MauiApp.1.csproj
Outdated
Show resolved
Hide resolved
85a8675
to
cd23c45
Compare
<Project Sdk="Microsoft.NET.Sdk"> | ||
|
||
<PropertyGroup> | ||
<TargetFramework>DOTNET_TFM</TargetFramework> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is a multi-project template... But can't the shared lib be multi-target? That will allow users to use the PlatformBehavior
nicely, and also access platform-specific APIs. I believe having this a multi-target will not break the multi-project structure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@davidortinau did you have any preference?
/rebase |
d30b399
to
5fbed49
Compare
src/Templates/src/templates/maui-multihead/.template.config/template.json
Outdated
Show resolved
Hide resolved
5fbed49
to
1cec4df
Compare
1cec4df
to
14fef58
Compare
This is just adding a template. The Android and Windows device/UI tests are unrelated and will be fixed in separate PRs. |
<PropertyGroup> | ||
<OutputType>WinExe</OutputType> | ||
<TargetFramework>DOTNET_TFM-windows10.0.19041.0</TargetFramework> | ||
<TargetPlatformMinVersion>10.0.17763.0</TargetPlatformMinVersion> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need a supportedosplatformversion here as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure. WinUI does not have it so I sort of wanted to keep it like winUI had.
src/Templates/src/templates/maui-multiproject/.template.config/template.json
Outdated
Show resolved
Hide resolved
471a3d0
to
6abda92
Compare
@mattleibow one question - how to create Multi-headed MAUI class library? Can we use this template with change |
You mean you want a class library with just a single TFM? You can just use a normal maui class library template - and then edit the TFM list to the one you want. |
Description of Change
Add the template that allows for the creation of multi-project templates.
Windows + CI is broken, so disabling the winui build for now: