Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the multi-project template #20365

Merged
merged 7 commits into from
Feb 15, 2024
Merged

Add the multi-project template #20365

merged 7 commits into from
Feb 15, 2024

Conversation

mattleibow
Copy link
Member

@mattleibow mattleibow commented Feb 5, 2024

Description of Change

Add the template that allows for the creation of multi-project templates.

Windows + CI is broken, so disabling the winui build for now:

@mattleibow mattleibow requested a review from a team as a code owner February 5, 2024 17:34
@mattleibow mattleibow force-pushed the dev/multihead branch 4 times, most recently from ddf7c00 to 4402b94 Compare February 6, 2024 18:35
@mattleibow mattleibow added this to the .NET 8 SR3 milestone Feb 6, 2024
@mattleibow mattleibow added the area-templates Project templates, Item Templates for Blazor and MAUI label Feb 6, 2024
@mattleibow mattleibow requested review from davidortinau, Redth and PureWeen and removed request for rmarinho and jsuarezruiz February 6, 2024 18:35
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>DOTNET_TFM</TargetFramework>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is a multi-project template... But can't the shared lib be multi-target? That will allow users to use the PlatformBehavior nicely, and also access platform-specific APIs. I believe having this a multi-target will not break the multi-project structure

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davidortinau did you have any preference?

@mattleibow
Copy link
Member Author

/rebase

@mattleibow
Copy link
Member Author

This is just adding a template. The Android and Windows device/UI tests are unrelated and will be fixed in separate PRs.

DianaSoltani
DianaSoltani previously approved these changes Feb 15, 2024
<PropertyGroup>
<OutputType>WinExe</OutputType>
<TargetFramework>DOTNET_TFM-windows10.0.19041.0</TargetFramework>
<TargetPlatformMinVersion>10.0.17763.0</TargetPlatformMinVersion>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a supportedosplatformversion here as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure. WinUI does not have it so I sort of wanted to keep it like winUI had.

@mattleibow mattleibow merged commit 37be10a into main Feb 15, 2024
1 of 39 checks passed
@mattleibow mattleibow deleted the dev/multihead branch February 15, 2024 20:21
@yevgeny-sotnikov
Copy link

yevgeny-sotnikov commented Mar 14, 2024

@mattleibow one question - how to create Multi-headed MAUI class library? Can we use this template with change <OutputType>Exe</OutputType> to <OutputType>Library</OutputType>? Thank you in advance

@mattleibow
Copy link
Member Author

You mean you want a class library with just a single TFM? You can just use a normal maui class library template - and then edit the TFM list to the one you want.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants