Remove Switch On/Off content

[dotMorten]

Description of Change

Removes the default On/Off text on the Windows ToggleSwitch. This brings consistency with iOS and Android, and avoids issues with not being able to style the text.

Issues Fixed

Fixes #20486

I've validated the fix with the Sandbox app. I'd love to add some unit tests too, but need a little guidance wrt where to put that, and how to verify that it no longer renders the text.

[ghost]

Hey there @dotMorten! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

[jsuarezruiz]

Hi Morten,

You have different ways to validate it with tests.
On the one hand, you can create a DeviceTests here https://github.com/dotnet/maui/blob/main/src/Core/tests/DeviceTests/Handlers/Switch/SwitchHandlerTests.Windows.cs#L16
Using xUnit you can create a test similar to https://github.com/dotnet/maui/blob/main/src/Core/tests/DeviceTests/Handlers/Switch/SwitchHandlerTests.cs#L14 where with a method you access the ToggleSwitch and you validate that the OffContent and OnContent properties are null.
You can also create a UITest, creating a golden test where a reference snapshot is created and the test compares each screenshot pixel by pixel with the reference. Example:

maui/src/Controls/tests/UITests/Tests/Issues/Issue17610.cs

Line 46 in b43f265

VerifyScreenshot();

[PureWeen]

Can you retarget this for net9.0?

[dotMorten]

@PureWeen Done!

[rmarinho]

Needs some kind of testing, think a UITest with a screenshot is fine

[jsuarezruiz]

Added Device Test.