[iOS] Readonly Editor - Scrolling fix #20505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Hey there @kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
kubaflo
changed the title
jsuarezruiz
reviewed
Feb 12, 2024
jsuarezruiz
previously requested changes
Feb 21, 2024
Eilon
added
the
legacy-area-controls
|
@jsuarezruiz I added a new commit |
jsuarezruiz
reviewed
Feb 22, 2024
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Eilon
removed
the
legacy-area-controls
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
mattleibow
previously approved these changes
Aug 21, 2024
| if (view is ITextInput textInput) | ||
| // Interaction should not be disabled for an editor if it is set as read-only | ||
| // because this prevents users from scrolling the content inside an editor. | ||
| if (view is not IEditor && view is ITextInput textInput) |
There was a problem hiding this comment.
I wonder if this is all wrong for IEntry too and we should be using the https://learn.microsoft.com/en-us/dotnet/api/uikit.uitextfielddelegate.shouldbeginediting?view=xamarin-ios-sdk-12
But this will still apply for the search bar. So we can do this (investigate at least) later.
# Conflicts: # src/Controls/tests/TestCases.HostApp/Issues/Issue19500.xaml # src/Controls/tests/TestCases.HostApp/Issues/Issue19500.xaml.cs
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
mattleibow
previously approved these changes
Aug 21, 2024
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
mattleibow
approved these changes
Aug 24, 2024
samhouts
added
the
fixed-in-net8.0-nightly
samhouts
added
the
fixed-in-net9.0-nightly
samhouts
added
fixed-in-9.0.0-rc.2.24503.2
and removed
fixed-in-net9.0-nightly
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Setting
UserinteractionEnabledto false prevents the editor from scrolling, so I replaced it with changing the value ofEditablebased on theIsReadOnlypropertyIssues Fixed
Fixes #19500
Screen.Recording.2024-02-11.at.14.41.57.mov