-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[iOS] Double dash in input field crash fix #20584
[iOS] Double dash in input field crash fix #20584
Conversation
Hey there @kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
using UITest.Appium; | ||
using UITest.Core; | ||
|
||
namespace Microsoft.Maui.AppiumTests.Issues |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
file-scoped namespace might be better
/rebase |
0fafc87
to
2be5aad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you take a look to the failing tests? Let me know, If you want me to check them myself.
Hi @kubaflo. We have added the "s/pr-needs-author-input" label to this issue, which indicates that we have an open question/action for you before we can take further action. This PRwill be closed automatically in 14 days if we do not hear back from you by then - please feel free to re-open it if you come back to this PR after that time. |
2be5aad
to
4059c37
Compare
@jsuarezruiz Sorry for the late response - I was pretty busy lately :) |
Don't worry, thanks for all your contributions. That test are passing now. |
/azp run MAUI-UITests-public |
Azure Pipelines successfully started running 1 pipeline(s). |
Description of Change
Using the length of the text based on the value from the iOS's text input rather than a control. It is because of the system's autocorrection that converts some combinations of characters into other symbols.
Issues Fixed
Fixes #20439
Fixes #19954
Fixes #15937
crash.mov
fixed.mov