SwipeGestureRecognizer return actual detected directions #20619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Hey there @espenrl! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
jsuarezruiz
approved these changes
Feb 22, 2024
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
rmarinho
approved these changes
Feb 23, 2024
|
/rebase |
github-actions
bot
force-pushed
the
SwipeGestureRecognizer
branch
from
19c2e50 to
dd50d44
Compare
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
As of the current behavior SwipeGestureRecognizer passes its
Directionproperty toSwipedEventArgsupon detection. That works for most scenarios, but it doesn't deal with the fact thatSwipeDirectionenum is a flag enumeration.An example where this becomes an issue. If SwipeGestureRecognizer is configured with
Direction = SwipeDirection.Up | SwipeDirection.Downand the actual detected direction isUptheSwipedEventArgs.Directionwill still beSwipeDirection.Up | SwipeDirection.Downand thus it's not possible to know what direction was actually detected.This PR makes sure the actual detected direction(s) is passed to SwipedEventArgs.