Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Upload build asset data to darc/maestro #20785

Merged
merged 6 commits into from
Feb 23, 2024
Merged

Conversation

pjcollins
Copy link
Member

The maui-release pipeline has been updated to publish information
about MAUI .NET .nupkg files to the dotnet Maestro server.

With this data being published, the darc tool can now be used to
manage a MAUI .NET product dependency.

For dependency updating to work, we must configure "default channel"
associations for all MAUI branches that other products may be interested
in tracking. The darc tool can be used to do this manually:

darc add-default-channel --channel ".NET 9.0.1xx SDK" --branch "net9.0" --repo https://github.com/dotnet/maui

This default channel configuration ensures that all new builds produced
by the net9.0 branch will be associated with the .NET 9 channel. MAUI
consumers can then update to the latest build available from net9.0 with
the update-dependencies command:

darc update-dependencies --channel ".NET 9.0.1xx SDK"

The `maui-release` pipeline has been updated to publish information
about MAUI .NET .nupkg files to the dotnet Maestro server.

With this data being published, the `darc` tool can now be used to
manage a MAUI .NET  product dependency.

For dependency updating to work, we must configure "default channel"
associations for all MAUI branches that other products may be interested
in tracking.  The `darc` tool can be used to do this manually:

    darc add-default-channel --channel ".NET 9.0.1xx SDK" --branch "net9.0" --repo https://github.com/dotnet/maui

This default channel configuration ensures that all new builds produced
by the net9.0 branch will be associated with the .NET 9 channel.  MAUI
consumers can then update to the latest build available from net9.0 with
the `update-dependencies` command:

    darc update-dependencies --channel ".NET 9.0.1xx SDK"
$darcVersion = $(Invoke-WebRequest -Uri $versionEndpoint -UseBasicParsing).Content
$arcadeServicesSource = 'https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-eng/nuget/v3/index.json'
& dotnet tool update microsoft.dotnet.darc --version "$darcVersion" --add-source "$arcadeServicesSource" --tool-path $(Agent.ToolsDirectory)\darc -v n
& $(Agent.ToolsDirectory)\darc\darc add-build-to-channel --default-channels --id $(BARBuildId) --publishing-infra-version 3 --skip-assets-publishing --password $(MaestroAccessToken) --azdev-pat $(publishing-dnceng-devdiv-code-r-build-re)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With these changes in place, we will need to make sure to manually create "default channels" for MAUI for every major branch, and also every time we create a new release/servicing branch:

darc add-default-channel --channel ".NET 9.0.1xx SDK" --branch "net9.0" --repo https://github.com/dotnet/maui

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah right now this is fine.. We can also add to the loop. @PureWeen knows the correct place for sure. He as looking at organising better our release process. Should it be on the wiki to be public?

@pjcollins pjcollins marked this pull request as ready for review February 23, 2024 19:32
@pjcollins pjcollins requested a review from a team as a code owner February 23, 2024 19:32
@pjcollins
Copy link
Member Author

Looks like this test build worked: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=9125468&view=logs&j=d60cae5e-2024-5790-45cc-e679bfe2722d

And I just pushed the dummy build to a test channel (since we have no default channels configured) - https://maestro-prod.westus2.cloudapp.azure.com/1647/https:%2F%2Fgh.neting.cc%2Fdotnet%2Fmaui/latest/graph

@rmarinho rmarinho merged commit 5a0a0bb into main Feb 23, 2024
44 of 51 checks passed
@rmarinho rmarinho deleted the dev/pjc/push-maestro branch February 23, 2024 19:49
rmarinho pushed a commit that referenced this pull request Feb 27, 2024
* [ci] Upload build asset data to darc/maestro

The `maui-release` pipeline has been updated to publish information
about MAUI .NET .nupkg files to the dotnet Maestro server.

With this data being published, the `darc` tool can now be used to
manage a MAUI .NET  product dependency.

For dependency updating to work, we must configure "default channel"
associations for all MAUI branches that other products may be interested
in tracking.  The `darc` tool can be used to do this manually:

    darc add-default-channel --channel ".NET 9.0.1xx SDK" --branch "net9.0" --repo https://github.com/dotnet/maui

This default channel configuration ensures that all new builds produced
by the net9.0 branch will be associated with the .NET 9 channel.  MAUI
consumers can then update to the latest build available from net9.0 with
the `update-dependencies` command:

    darc update-dependencies --channel ".NET 9.0.1xx SDK"

* Remove test props

* Fix argument indent

* Fix version prefix

* Add EnsureTrailingSlash to outdir

* Remove variable condition
@github-actions github-actions bot locked and limited conversation to collaborators Mar 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants