Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if CV Item Handler has been created #20900

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Check if CV Item Handler has been created #20900

merged 1 commit into from
Feb 28, 2024

Conversation

PureWeen
Copy link
Member

@PureWeen PureWeen commented Feb 28, 2024 •
edited
Loading

Description of Change

When a CV is nested inside a VerticalStackLayout it will get measured and have its CollectionView.SelectItem set before the content of the TemplatedCells has been created, as the TemplatedCells are created during the Dequeue process, iOS well set the Selected property to true before we realize the handlers. So, we need to not react off of selected being changed until the handler has been bound to the TemplatedCell

Issues Fixed

Fixes #20606

@PureWeen PureWeen requested a review from a team as a code owner February 28, 2024 18:54
@PureWeen PureWeen mentioned this pull request Feb 28, 2024
Closed
@PureWeen
Copy link
Member Author

Failing tests unrelated

@PureWeen PureWeen merged commit be98c17 into main Feb 28, 2024
39 of 47 checks passed
@PureWeen PureWeen deleted the fix-20606-with_test branch February 28, 2024 21:08
@github-actions github-actions bot locked and limited conversation to collaborators Mar 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rmarinho rmarinho rmarinho approved these changes

@mattleibow mattleibow Awaiting requested review from mattleibow mattleibow is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

@jsuarezruiz jsuarezruiz Awaiting requested review from jsuarezruiz jsuarezruiz is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

Assignees
No one assigned
Labels
fixed-in-8.0.10 fixed-in-9.0.0-preview.2.10247 fixed-in-9.0.0-preview.2.10293
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[iOS] NullReferenceException in TemplatedCell
3 participants
@PureWeen @rmarinho @samhouts