Don't remeasure the HScrollView during the layout pass #20998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PureWeen
force-pushed
the
fix_nested_scrollview
branch
from
d1d2884 to
1bdae41
Compare
PureWeen
force-pushed
the
fix_nested_scrollview
branch
from
0408f1f to
2d7fe69
Compare
PureWeen
changed the title
rmarinho
approved these changes
Mar 5, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
#19349 created an issue with nested scrollviews that was causing the layout calls to thrash. Because we were calling "Measure" on the hScroll during the layout pass, this would reset the height/width on the frame during layout, which would then cause "requestLayout" to schedule a "requestLayout" on the UI thread. Which would then cause the loop to trigger again.
This PR attempts keep the measures with the measures and the layouts with the layouts.
Issues Fixed
Fixes #20920