[X] do not apply Bindings if DataType doesnt match

[StephaneDelcroix]

Reverted for SR8

#24046

This should be part of SR9
#23989

Description of Change

Make sure the behavior of bindings is consistent accross implementations (compiled/not compiled)

fixes a bunch of issues

Issues Fixed

• fixes Improve information/experience around x:DataType behaviour in Debug vs Release #21735
• fixes when I release an APP, it can't display binding data properly, but it will display properly when I run it in debug mode. #16414
• fixes XamlC resolves x:DataType incorrectly #11956
• fixes Binding CollectionView/CarouselView to lists of primitive types doesn't work on Release Builds #16021
• fixes .NET MAUI CarouselView Items Not Visible in Release Mode #19357

[PureWeen]

/rebase

[PureWeen]

/rebase

[PureWeen]

One the compatibility UI tests pass on this run
https://dev.azure.com/xamarin/public/_build/results?buildId=119409&view=results

let's merge

[PureWeen]

/backport to net9.0

[github-actions]

Started backporting to net9.0: https://github.com/dotnet/maui/actions/runs/10060482744

[github-actions]

@PureWeen backporting to net9.0 failed, the patch most likely resulted in conflicts:

$ git am --3way --ignore-whitespace --keep-non-patch changes.patch

Applying: [X] do not apply Bindings if DataType doesnt match
.git/rebase-apply/patch:180: trailing whitespace.
			
.git/rebase-apply/patch:181: trailing whitespace.
			[Test] 
.git/rebase-apply/patch:190: trailing whitespace.
			
.git/rebase-apply/patch:191: trailing whitespace.
			[Test] 
warning: 4 lines add whitespace errors.
Using index info to reconstruct a base tree...
M	src/Controls/src/Core/Binding.cs
M	src/Controls/src/Xaml/MarkupExtensions/BindingExtension.cs
M	src/Controls/src/Xaml/XamlServiceProvider.cs
M	src/Controls/tests/Xaml.UnitTests/BindingsCompiler.xaml.cs
Falling back to patching base and 3-way merge...
Auto-merging src/Controls/tests/Xaml.UnitTests/BindingsCompiler.xaml.cs
Auto-merging src/Controls/src/Xaml/XamlServiceProvider.cs
CONFLICT (content): Merge conflict in src/Controls/src/Xaml/XamlServiceProvider.cs
Auto-merging src/Controls/src/Xaml/MarkupExtensions/BindingExtension.cs
CONFLICT (content): Merge conflict in src/Controls/src/Xaml/MarkupExtensions/BindingExtension.cs
Auto-merging src/Controls/src/Core/Binding.cs
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 [X] do not apply Bindings if DataType doesnt match
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

[github-actions]

@PureWeen an error occurred while backporting to net9.0, please check the run log for details!

Error: git am failed, most likely due to a merge conflict.

[AlleSchonWeg]

Hi @simonrozsival ,
i updated my app to the latest nightly build and now i receive this warnings:

Microsoft.Maui.Controls.Xaml.Diagnostics.BindingDiagnostics: Warning: Mismatch between the specified x:DataType and the current binding context

Is it possible to add more infos to this warning which can help to find easier the cause? Perhaps the type specified in x:DataType and current BindingContext type which not match?!

Thank you

[simonrozsival]

@AlleSchonWeg thanks for the feedback. What you suggest makes sense. Could you please open a new issue so that we can track it more easily?

[AlleSchonWeg]

@simonrozsival
Issue created: #24349 😎