Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] FlyoutPage Shadow works incorrectly on iOS - fix #22351

Merged
merged 3 commits into from
May 13, 2024

Conversation

kubaflo
Copy link
Contributor

@kubaflo kubaflo commented May 12, 2024

Fixes #22169

Before After
Simulator.Screen.Recording.-.iPad.mini.6th.generation.-.2024-05-12.at.14.08.58.mp4
Simulator.Screen.Recording.-.iPad.mini.6th.generation.-.2024-05-12.at.13.41.16.mp4

@kubaflo kubaflo requested a review from a team as a code owner May 12, 2024 12:20
@kubaflo kubaflo requested review from jfversluis and rmarinho May 12, 2024 12:20
@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label May 12, 2024
@@ -694,7 +694,9 @@ bool shouldReceive(UIGestureRecognizer g, UITouch t)

if (_applyShadow)
{
var openProgress = targetFrame.X / flyoutWidth;
var openProgress = !IsRTL
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to apply this logic here also?

if (_applyShadow)
{
var openProgress = targetFrame.X / _flyoutController.View.Frame.Width;
ApplyDetailShadow((nfloat)openProgress);

If yes, then maybe we modify ApplyDetailShadow and pass in all these things as parameters so we're not duplicated.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I've added another commit with a small change that fixes it

@jsuarezruiz
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@PureWeen PureWeen merged commit b2870c7 into dotnet:main May 13, 2024
49 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FlyoutPage Shadow works incorrectly on iOS
4 participants