-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[arcade] Move to arcade 8.0 for main and to use new Version system #22400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eilon
added
the
area-infrastructure
CI, Maestro / Coherency, upstream dependencies/versions
label
May 14, 2024
rmarinho
changed the title
[arcade] Move to arcade 8.0 for main
[arcade] Move to arcade 8.0 for main and to use new Version system
May 15, 2024
rmarinho
requested review from
mattleibow and
PureWeen
and removed request for
StephaneDelcroix and
jfversluis
May 15, 2024 15:38
mattleibow
approved these changes
May 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area-infrastructure
CI, Maestro / Coherency, upstream dependencies/versions
fixed-in-8.0.60
fixed-in-9.0.0-preview.5.24307.10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This pull request introduces several changes to the versioning system for our handler, leveraging the .NET Arcade versioning rules. The changes include moving the arcade to the 8.0 channel and updating xharness. This update ensures that our versioning scheme aligns with the established rules and practices, enhancing consistency and predictability in our build process.
Key Changes
Versioning Scheme
Taking the following example:
The
PatchNumberDate
is calculated based on the format "yyyymmdd.Rev", producing something like 24264.1.8.0.40-dev.{PatchNumberDate}
8.0.40-ci.{PatchNumberDate}
Branching Strategy
Servicing Branches:
PreReleaseVersionLabel
toservicing
and setStabilizePackageVersion
to true.Release servicing - 8.0.40
Preview Branches:
PreReleaseVersionLabel
topreview
, thePreReleaseInteractionVersion
to the number of you want and setStabilizePackageVersion
to true.Release previews - 8.0.40-preview.1.{PatchNumberDate}
Implementation Examples
8.0.40-dev.24264.1
8.0.40-ci.24264.1
8.0.40
9.0.0-preview.1.24264.1
Documentation Reference
For detailed versioning rules and additional context, refer to the Arcade versioning documentation.
This pull request helps ensuring our versioning system is robust, predictable, facilitating better build management and release processes.
Update of package versions:
.config/dotnet-tools.json
: Updated theMicrosoft.DotNet.XHarness.CLI
package version from9.0.0-prerelease.24256.1
to9.0.0-prerelease.24263.1
.eng/Version.Details.xml
: Updated the versions ofMicrosoft.DotNet.XHarness.TestRunners.Common
,Microsoft.DotNet.XHarness.TestRunners.Xunit
, andMicrosoft.DotNet.XHarness.CLI
packages.eng/Versions.props
: Updated the versions ofMicrosoft.DotNet.XHarness.TestRunners.Common
,Microsoft.DotNet.XHarness.TestRunners.Xunit
, andMicrosoft.DotNet.XHarness.CLI
packages.Removal of
productBuild
option:eng/common/build.ps1
: Removed theproductBuild
option from the build script. [1] [2] [3]eng/common/build.sh
: Removed theproductBuild
option from the build script. [1] [2] [3] [4]Other changes:
eng/cake/dotnet.cake
: Added theofficialBuildId
argument to thedotnet-pack-maui
task. [1] [2]Directory.Build.props
andeng/Environment.Build.props
: Moved the condition for importingEnvironment.Build.props
to the top ofDirectory.Build.props
and added aContinuousIntegrationBuild
condition inEnvironment.Build.props
. [1] [2] [3]eng/Versions.props
andeng/Versions.targets
: Made changes related to versioning and build characteristics. [1] [2] [3] [4]eng/common/build.cmd
: The entire file was removed.