Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[net9.0] Merge main to net9.0 #22840

Merged
merged 15 commits into from
Jun 5, 2024
Merged

[net9.0] Merge main to net9.0 #22840

merged 15 commits into from
Jun 5, 2024

Conversation

rmarinho
Copy link
Member

@rmarinho rmarinho commented Jun 4, 2024

Description of Change

Bring latest changes from main to net9 branch

jfversluis and others added 14 commits June 3, 2024 13:01
* Remove .NET 7 from bug template

* Update bug-report.yml

* Update bug-report.yml
…22583)

* Support changing Window coords during a change

Fixes #21306

* Skip the tests for now as they still hang
* Make sure the package source mapping is correct

* Update NuGet.config

* Update NuGet.config

* Update NuGet.config

* skia

* Update NuGet.config

* Make things a bit better, maybe

* Update NuGet.config

* things

* version placeholders

* Update NuGet.config
I used to do this to build MAUI:

* `dotnet cake`

* `./bin/dotnet/dotnet build SomeCustomerProject.csproj`

Unfortunately, the `dotnet build` command would give an error
that the MAUI workload was not installed.

The `Microsoft.Maui.Sdk` project is copying its output to:

    OutputPath = artifacts/bin/Microsoft.Maui.Sdk/Debug/

When it should be:

    OutputPath = bin/dotnet/packs/Microsoft.Maui.Sdk/8.0.60-dev/

This appears to be caused by the migration to dotnet/arcade:

https://github.com/dotnet/arcade/blob/e6b3f32f9855dccbe2447471c8f729b66f17d242/src/Microsoft.DotNet.Arcade.Sdk/tools/ProjectLayout.props#L14

To fix this, I added a new target to copy files to an additional location.

After this change, I still got a warning:

    warning NU1603: hellomaui depends on Microsoft.Maui.Controls (>= 8.0.60-dev) but Microsoft.Maui.Controls 8.0.60-dev was not found. An approximate best match of Microsoft.Maui.Controls 8.0.60-dev.24303.1 was resolved.

But will troubleshoot that one later, the `.nupkg` files in
`./bin/dotnet/library-packs/`, have a 8.0.60-dev.24303.1 version.
…40527.1 (#22791)

Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
 From Version 9.0.0-prerelease.24270.4 -> To Version 9.0.0-prerelease.24277.1

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
* Added some additional testing assets to sandbox

* Do more sample things
* Reduce the number of calls to invalidate measure

* Added UITest

* - add screen shot

* Updated tests validating more Label updates

* Updated snapshot

---------

Co-authored-by: Javier Suárez <javiersuarezruiz@hotmail.com>
Co-authored-by: Shane Neuville <shneuvil@microsoft.com>
* Fixing _loaded event firing logic

* Added a unit test for checking a raising count of page Loaded/UnLoaded events

* - add test and fix code to maintain initial intent

---------

Co-authored-by: Rafal Kukla <rafal.kukla@tietoevry.com>
Co-authored-by: Shane Neuville <shneuvil@microsoft.com>
If you try to F5 the Windows device tests, you'll get an error:

    Error (active) APPX1101 Payload contains two or more files with the same destination path 'xunit.runner.utility.netcoreapp10.dll'. Source files:
    ...\Microsoft.Maui.Cache\NuGet\packages\xunit.runner.visualstudio\2.8.0\build\net6.0\xunit.runner.utility.netcoreapp10.dll
    ...\Microsoft.Maui.Cache\NuGet\packages\xunit.runner.utility\2.6.6\lib\netcoreapp1.0\xunit.runner.utility.netcoreapp10.dll	Controls.DeviceTests (net8.0-windows10.0.19041.0)
    ...\Microsoft.Maui.Cache\NuGet\packages\microsoft.windowsappsdk\1.5.240311000\buildTransitive\Microsoft.Build.Msix.Packaging.targets

This is due to dotnet/arcade using:

https://github.com/dotnet/arcade/blob/2c08708d18855f2e2779ac5d0623a5978751c4f3/src/Microsoft.DotNet.Arcade.Sdk/tools/XUnit/XUnit.targets#L13

For now, let's set `$(DisableArcadeTestFramework)` and it won't import
`XUnit.targets` from arcade.

After these changes, I can F5 again.
# Conflicts:
#	NuGet.config
#	eng/Version.Details.xml
#	src/Controls/src/Core/Interactivity/EventTrigger.cs
#	src/Core/src/PublicAPI/net-ios/PublicAPI.Unshipped.txt
#	src/Core/src/PublicAPI/net-maccatalyst/PublicAPI.Unshipped.txt
@rmarinho rmarinho added the area-infrastructure CI, Maestro / Coherency, upstream dependencies/versions label Jun 4, 2024
@rmarinho rmarinho requested a review from a team as a code owner June 4, 2024 21:12
@rmarinho rmarinho merged commit 69a4cfc into net9.0 Jun 5, 2024
47 of 51 checks passed
@rmarinho rmarinho deleted the merge-net9-main branch June 5, 2024 15:15
@github-actions github-actions bot locked and limited conversation to collaborators Jul 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-infrastructure CI, Maestro / Coherency, upstream dependencies/versions fixed-in-9.0.0-preview.5.24307.10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants