Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/6.0.1xx-rc1] Update dependencies from xamarin/xamarin-android #2369

Commits on Sep 2, 2021

  1. Update dependencies from https://github.com/xamarin/xamarin-android b…

    …uild 6.0.1xx-rc1-3793f6e34c40e3aa1a00d0dbe6dd0d706283e197-1
    
    Microsoft.Android.Sdk.Windows
     From Version 31.0.100-rc.1.12 -> To Version 31.0.100-rc.1.16
    
    Dependency coherency updates
    
    Microsoft.NETCore.App.Ref,Microsoft.Dotnet.Sdk.Internal,Microsoft.Extensions.Primitives,Microsoft.AspNetCore.App.Runtime.win-x64,Microsoft.Extensions.Hosting,Microsoft.Extensions.Hosting.Abstractions,Microsoft.Extensions.DependencyInjection.Abstractions,Microsoft.Extensions.DependencyInjection,Microsoft.Extensions.Configuration.Abstractions,Microsoft.Extensions.Configuration,Microsoft.Extensions.Logging.Abstractions,Microsoft.Extensions.Logging,Microsoft.Extensions.Logging.Console,Microsoft.Extensions.Logging.Debug,Microsoft.Extensions.FileProviders.Abstractions,Microsoft.AspNetCore.Authorization,Microsoft.AspNetCore.Components.WebView,Microsoft.AspNetCore.Components.Web,Microsoft.JSInterop,Microsoft.WindowsDesktop.App.Runtime.win-x64,System.CodeDom
     From Version 6.0.0-rc.1.21426.8 -> To Version 6.0.0-rc.1.21451.13 (parent: Microsoft.Dotnet.Sdk.Internal
    dotnet-maestro[bot] committed Sep 2, 2021
    Configuration menu
    Copy the full SHA
    5a3f15c View commit details
    Browse the repository at this point in the history
  2. Remove incorrect LangVersion 9.0 and use default

    Razor Source Generator needs at least 10.0
    Eilon committed Sep 2, 2021
    Configuration menu
    Copy the full SHA
    e2ba46a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b29e195 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2021

  1. Use $(LangVersion) preview, because dotnet/maui builds with VS

    Context: dotnet/sdk@10efeed...454eae3
    
    This was removed from the dotnet/sdk:
    
        <!-- Required to support incremental source generator -->
        <LangVersion Condition="'$(UseRazorSourceGenerator)' != '' ">preview</LangVersion>
    
    So I think we need to opt into `preview` to build with the older
    Roslyn in VS.
    jonathanpeppers committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    a73c6fe View commit details
    Browse the repository at this point in the history
  2. Keep Controls.Core.UnitTests on C# 9

    This apparently breaks NUnit `Assert.That()` calls.
    
    I could build the project locally after this change.
    jonathanpeppers committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    47de1f3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    85ce42d View commit details
    Browse the repository at this point in the history
  4. Revert "Try start vs4mac with local dotnet"

    This reverts commit 85ce42d.
    jonathanpeppers committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    989bc16 View commit details
    Browse the repository at this point in the history
  5. Update LifecycleEventsTests.cs

    I think we might also be hitting some method overloading issues in these test failures:
    
    * `CanAddMultipleEventsViaMultipleConfigureLifecycleEvents`
    * `CanAddMultipleEventsViaBuilder`
    * `EventsFireExactlyOnce`
    jonathanpeppers committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    90c233d View commit details
    Browse the repository at this point in the history
  6. Revert "Update LifecycleEventsTests.cs"

    This reverts commit 90c233d.
    jonathanpeppers committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    48f708d View commit details
    Browse the repository at this point in the history
  7. Keep Core.UnitTests on C# 9

    This solves 3 test failures:
    
        > .\bin\dotnet\dotnet.exe test src\Core\tests\UnitTests\Core.UnitTests-net6.csproj -bl
        ...
        [xUnit.net 00:00:00.60]     CanAddMultipleEventsViaMultipleConfigureLifecycleEvents [FAIL]
        Failed CanAddMultipleEventsViaMultipleConfigureLifecycleEvents [10 ms]
        Error Message:
            Assert.Equal() Failure
            Expected: 1
            Actual:   0
        Stack Trace:
            at Microsoft.Maui.UnitTests.LifecycleEvents.LifecycleEventsTests.CanAddMultipleEventsViaMultipleConfigureLifecycleEvents() in C:\src\maui\src\Core\tests\UnitTests\LifecycleEvents\LifecycleEventsTests.cs:line 134
        [xUnit.net 00:00:00.62]     EventsFireExactlyOnce [FAIL]
        [xUnit.net 00:00:00.62]     CanAddMultipleEventsViaBuilder [FAIL]
        Failed EventsFireExactlyOnce [2 ms]
        Error Message:
            Assert.Equal() Failure
            Expected: 1
            Actual:   0
        Stack Trace:
            at Microsoft.Maui.UnitTests.LifecycleEvents.LifecycleEventsTests.EventsFireExactlyOnce() in C:\src\maui\src\Core\tests\UnitTests\LifecycleEvents\LifecycleEventsTests.cs:line 75
        Failed CanAddMultipleEventsViaBuilder [2 ms]
        Error Message:
            Assert.Equal() Failure
            Expected: 1
            Actual:   0
        Stack Trace:
            at Microsoft.Maui.UnitTests.LifecycleEvents.LifecycleEventsTests.CanAddMultipleEventsViaBuilder() in C:\src\maui\src\Core\tests\UnitTests\LifecycleEvents\LifecycleEventsTests.cs:line 156
        Failed!  - Failed:     3, Passed:   367, Skipped:     0, Total:   370, Duration: 192 ms - Microsoft.Maui.UnitTests.dll (net6.0)
    jonathanpeppers committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    af1749e View commit details
    Browse the repository at this point in the history
  8. Merge branch 'release/6.0.1xx-rc1' into darc-release/6.0.1xx-rc1-cd99…

    …50e4-1860-4e4e-88b6-076f82a5d302
    rmarinho authored Sep 3, 2021
    Configuration menu
    Copy the full SHA
    85b3313 View commit details
    Browse the repository at this point in the history