Fixed low quality images in Resizetizer

[TommiGustafsson-HMP]

Description of Change

Added FilterQuality = SKFilterQuality.High to Paint in SkiaSharpTools. This fixes low quality images produced by Resizetizer.

Issues Fixed

[Windows] [.NET 9.0 Preview 5] App icon in the taskbar is pixelated (#23212).

Fixes #23212.

[mattleibow]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).

[mattleibow]

Thanks for this PR! This is probably going to make a whole lot of images better that folks didn't even notice was poor quality.

[mattleibow]

/rebase

[mattleibow]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).

[rmarinho]

Tests are failing https://dev.azure.com/xamarin/public/_build/results?buildId=120966&view=ms.vss-test-web.build-test-results-tab&runId=3008137&resultId=100048&paneView=debug

[TommiGustafsson-HMP]

Are the failing tests comparing some pre-rendered images? Because I added the High Quality filter, the resulting images can be different than before.

[MartyIX]

The debug message says:

Image was not equal. Error was 0.15364583333333334% (53241 pixels). See /Users/builder/azdo/_work/2/s/artifacts/bin/Resizetizer.UnitTests/Release/net8.0/../../../../../src/SingleProject/Resizetizer/test/UnitTests/errors/imageresults/ResizetizeImagesTests+ExecuteForAndroid/SingleRasterAppIconWithOnlyPathSucceedsWithoutVectors/output-camera-folderSLASHthe_alias.png-m-i.mask.png

so yes, it appears so.

https://dev.azure.com/xamarin/public/_build/results?buildId=120966&view=logs&jobId=c735c3c0-2f10-555e-4625-3331c8e9237d&j=c735c3c0-2f10-555e-4625-3331c8e9237d&t=c290249e-238e-5254-445d-aaabf06dd42c (tests running on macOS) contains a raw log file containing:

2024-08-07T11:22:10.0678190Z   Failed Microsoft.Maui.Resizetizer.Tests.ResizetizeImagesTests+ExecuteForAndroid.SingleRasterAppIconWithOnlyPathSucceedsWithoutVectors(name: "camera_color", alias: "camera_color", outputName: "camera_color") [255 ms]
2024-08-07T11:22:10.0711150Z   Error Message:
2024-08-07T11:22:10.0713800Z    Image was not equal. Error was 0.1931423611111111% (27702 pixels). See /Users/builder/azdo/_work/2/s/artifacts/bin/Resizetizer.UnitTests/Release/net8.0/../../../../../src/SingleProject/Resizetizer/test/UnitTests/errors/imageresults/ResizetizeImagesTests+ExecuteForAndroid/SingleRasterAppIconWithOnlyPathSucceedsWithoutVectors/output-camera_color-camera_color-m-i.mask.png

[mattleibow]

I regenerated all the images, so let's see. Also, we can see the results of this.

[mattleibow]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).

[MartyIX]

e.g. https://github.com/dotnet/maui/pull/23924/files#diff-313284cd59f4dcdb8a6eb6807edcbd2d0c656c368fafce2f3458da1d31e9ddcd looks very nice now

[TommiGustafsson-HMP]

@dotnet-policy-service agree [company="Hyvän mielen pelit ry"]

[TommiGustafsson-HMP]

@dotnet-policy-service agree company="Hyvän mielen pelit ry"

[mattleibow]

The CollectionScrollToGroupWorks test is new and failing on main. Unrelated to this PR.

[KeithBoynton]

How do I work out which release this will be included in?

[MartyIX]

@KeithBoynton With very high probability, it will be in the next .NET 8 SR9 release.

[KeithBoynton]

Thanks very much @MartyIX is there somewhere I can track that please?

[MartyIX]

Thanks very much @MartyIX is there somewhere I can track that please?

It can be complicated but the general rule is that what is in the main branch will be in the next .NET 8 service release. However, at some point a branch like https://github.com/dotnet/maui/tree/release/8.0.1xx-sr8 can appear and changes to main are no longer added to that branch. So when a release is very close then what is in main will be in the next release does not old.

There can be last minute changes based on testing.

btw: Changes for .NET 9 goes to the net9.0 branch.

PS: You can watch https://github.com/orgs/dotnet/projects/194/views/39 but it does not reflect reality 1:1.