Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shadow consistency on Android and iOS #24415

Merged
merged 2 commits into from
Sep 3, 2024

Conversation

albyrock87
Copy link
Contributor

@albyrock87 albyrock87 commented Aug 24, 2024

Description of Change

As shown in #24414 shadows are not rendered properly in Android and iOS.

  • Android: dp are not being converted to px
  • iOS: it's strange, I know, but the radius renders twice its size

This PR fixes it, making as much consistent as possible with Figma.
Android is still not perfect, but it is very close.

image

image

Issues Fixed

Fixes #24414
Relates to #8796

@albyrock87 albyrock87 requested a review from a team as a code owner August 24, 2024 14:11
@albyrock87 albyrock87 requested review from Eilon and jfversluis August 24, 2024 14:11
@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Aug 24, 2024
Copy link
Contributor

Hey there @albyrock87! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@PureWeen
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@PureWeen
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@albyrock87 albyrock87 force-pushed the mobile-shadow-consistency branch from aea0080 to 9b1153b Compare August 26, 2024 09:25
@PureWeen
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@samhouts samhouts added the area-drawing Shapes, Borders, Shadows, Graphics, BoxView, custom drawing label Aug 27, 2024
@mattleibow
Copy link
Member

Just linking this one for linking things: #24561

Copy link
Member

@mattleibow mattleibow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really nice!

@PureWeen PureWeen merged commit 642a352 into dotnet:main Sep 3, 2024
97 checks passed
@albyrock87 albyrock87 deleted the mobile-shadow-consistency branch September 4, 2024 09:54
@samhouts samhouts added the fixed-in-net8.0-nightly This may be available in a nightly release! label Sep 5, 2024
@samhouts samhouts added the fixed-in-net9.0-nightly This may be available in a nightly release! label Oct 1, 2024
@samhouts samhouts added fixed-in-9.0.0-rc.2.24503.2 and removed fixed-in-net9.0-nightly This may be available in a nightly release! fixed-in-net8.0-nightly This may be available in a nightly release! labels Oct 14, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Nov 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-drawing Shapes, Borders, Shadows, Graphics, BoxView, custom drawing community ✨ Community Contribution fixed-in-9.0.0-rc.2.24503.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shadows not rendering as expected on Android and iOS
4 participants