Don't invalidate SuperView if not connected to Window #24637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PureWeen
requested review from
Eilon,
jsuarezruiz,
Redth and
mattleibow
and removed request for
Eilon and
jsuarezruiz
mattleibow
reviewed
Sep 9, 2024
mattleibow
approved these changes
Sep 9, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
I rolled back these changes on a previous PR because they caused a regression when modifying a layout that's offscreen
#24477
From testing, I found that the main part that caused a regression was the "setNeedsLayout" changes inside LayoutView.
It's interesting because now with this PR the setNeedsLayout calls inside LayoutView aren't really even needed.
A user reported that they were occasionally still seeing the exception so I've taken a different approach here and have it refire
SetNeedsLayouton the parent if the view gets reattached to the window.Issues Fixed
Fixes #24032