Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't invalidate SuperView if not connected to Window #24637

Merged
merged 2 commits into from
Sep 9, 2024
Merged

Conversation

PureWeen
Copy link
Member

@PureWeen PureWeen commented Sep 6, 2024

Description of Change

I rolled back these changes on a previous PR because they caused a regression when modifying a layout that's offscreen
#24477

From testing, I found that the main part that caused a regression was the "setNeedsLayout" changes inside LayoutView.

It's interesting because now with this PR the setNeedsLayout calls inside LayoutView aren't really even needed.

A user reported that they were occasionally still seeing the exception so I've taken a different approach here and have it refire SetNeedsLayout on the parent if the view gets reattached to the window.

Issues Fixed

Fixes #24032

@PureWeen PureWeen requested a review from a team as a code owner September 6, 2024 21:28
@PureWeen PureWeen requested review from Eilon, jsuarezruiz, Redth and mattleibow and removed request for Eilon and jsuarezruiz September 6, 2024 21:28
@mattleibow mattleibow merged commit 72aa284 into main Sep 9, 2024
97 checks passed
@mattleibow mattleibow deleted the fix_24032 branch September 9, 2024 15:52
@github-actions github-actions bot locked and limited conversation to collaborators Oct 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash on ios when open new screen or navigate back to it
3 participants