[android] update Xamarin.Google.Guava.ListenableFuture #5305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: xamarin/AndroidX#509 Building a MAUI project with a certain set of AndroidX dependencies: <PackageReference Include="Xamarin.AndroidX.Core" Version="1.7.0" /> <PackageReference Include="Xamarin.AndroidX.Camera.Lifecycle" Version="1.0.2.3" /> <PackageReference Include="Xamarin.AndroidX.Camera.Camera2" Version="1.0.2.3" /> <PackageReference Include="Xamarin.AndroidX.Camera.View" Version="1.0.0.5-alpha20" /> Fails with: Xamarin.Android.D8.targets(79,5): error : java.lang.RuntimeException: com.android.tools.r8.CompilationFailedException: Compilation failed to complete, origin: /Users/imac/.nuget/packages/xamarin.google.guava.listenablefuture/1.0.0.5/buildTransitive/net6.0-android31.0/../../jar/guava-listenablefuture.jar : com/google/common/util/concurrent/ListenableFuture.class If we look at the contents of: C:\Program Files\dotnet\packs\Microsoft.Maui.Controls.Ref.android\6.0.200-preview.14.5099\ref\net6.0-android30.0\Microsoft.Maui.Controls.aar There is a `libs\FCEFAF10B0757418.jar` inside that contains the contents of `guava-listenablefuture.jar`! This was a fix for `Xamarin.Google.Guava.*`: xamarin/XamarinComponents#1313 MAUI is not using the latest version of this package, so we can specify `Xamarin.Google.Guava.ListenableFuture` explicitly. Now there are no `.jar` files in `Microsoft.Maui.aar`. Another approach is to update to the very latest AndroidX packages -- right now we are blocked on trying to get them all on the `dotnet-public` feed. So we can take that approach later on.
jpobst
approved these changes
Mar 15, 2022
|
So
However, some things still fail to build complaining about guava, need to look into it... |
|
This package also has it inside! https://www.nuget.org/api/v2/package/Xamarin.AndroidX.Concurrent.Futures/1.1.0.5 The 1.1.0.6 one seems ok. |
|
I keep hitting issues here with other dependencies, I think we just need to update AndroidX to fix this problem. |
|
Do you know if there is an update on this or a workaround? I am still unable to start up my .NET MAUI project |
jonathanpeppers
added a commit
to jonathanpeppers/maui
that referenced
this pull request
Mar 25, 2022
Context: dotnet#5305 Fixes: xamarin/AndroidX#509 Update to the latest AndroidX packages, so we also use the latest Xamarin.Google.Guava.ListenableFuture This currently has build failures: src\Core\src\Platform\Android\Navigation\StackNavigationManager.cs(145,41): error CS1061: 'NavController' does not contain a definition for 'BackStack' and no accessible extension method 'BackStack' accepting a first argument of type 'NavController' could be found (are you missing a using directive or an assembly reference?) src\Core\src\Platform\Android\Navigation\StackNavigationManager.cs(188,48): error CS1061: 'NavController' does not contain a definition for 'BackStack' and no accessible extension method 'BackStack' accepting a first argument of type 'NavController' could be found (are you missing a using directive or an assembly reference?) src\Core\src\Platform\Android\Navigation\StackNavigationManager.cs(245,51): error CS1061: 'NavController' does not contain a definition for 'BackStack' and no accessible extension method 'BackStack' accepting a first argument of type 'NavController' could be found (are you missing a using directive or an assembly reference?) Looking at: ~\.nuget\packages\xamarin.androidx.navigation.runtime\2.4.1\lib\net6.0-android31.0\Xamarin.AndroidX.Navigation.Runtime.dll I can't find: [Register("androidx/navigation/NavController", DoNotGenerateAcw = true)] public class NavController : Object { public unsafe virtual IDeque BackStack { [Register("getBackStack", "()Ljava/util/Deque;", "GetGetBackStackHandler")] get; But it's not documented here either: https://developer.android.com/reference/androidx/navigation/NavController
|
Closing in favor of #5588 |
Redth
pushed a commit
that referenced
this pull request
Mar 29, 2022
* [android] update to the latest AndroidX packages Context: #5305 Fixes: xamarin/AndroidX#509 Update to the latest AndroidX packages, so we also use the latest Xamarin.Google.Guava.ListenableFuture This currently has build failures: src\Core\src\Platform\Android\Navigation\StackNavigationManager.cs(145,41): error CS1061: 'NavController' does not contain a definition for 'BackStack' and no accessible extension method 'BackStack' accepting a first argument of type 'NavController' could be found (are you missing a using directive or an assembly reference?) src\Core\src\Platform\Android\Navigation\StackNavigationManager.cs(188,48): error CS1061: 'NavController' does not contain a definition for 'BackStack' and no accessible extension method 'BackStack' accepting a first argument of type 'NavController' could be found (are you missing a using directive or an assembly reference?) src\Core\src\Platform\Android\Navigation\StackNavigationManager.cs(245,51): error CS1061: 'NavController' does not contain a definition for 'BackStack' and no accessible extension method 'BackStack' accepting a first argument of type 'NavController' could be found (are you missing a using directive or an assembly reference?) Looking at: ~\.nuget\packages\xamarin.androidx.navigation.runtime\2.4.1\lib\net6.0-android31.0\Xamarin.AndroidX.Navigation.Runtime.dll I can't find: [Register("androidx/navigation/NavController", DoNotGenerateAcw = true)] public class NavController : Object { public unsafe virtual IDeque BackStack { [Register("getBackStack", "()Ljava/util/Deque;", "GetGetBackStackHandler")] get; But it's not documented here either: https://developer.android.com/reference/androidx/navigation/NavController * - replace with BackQueue * - fix tests * $(NoWarn) XA4218 * $(MSBuildWarningsAsMessages) I mean Co-authored-by: Shane Neuville <shneuvil@microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: xamarin/AndroidX#509
Building a MAUI project with a certain set of AndroidX dependencies:
Fails with:
If we look at the contents of:
There is a
libs\FCEFAF10B0757418.jarinside that contains thecontents of
guava-listenablefuture.jar!This was a fix for
Xamarin.Google.Guava.*:xamarin/XamarinComponents#1313
MAUI is not using the latest version of this package, so we can
specify
Xamarin.Google.Guava.ListenableFutureexplicitly. Now thereare no
.jarfiles inMicrosoft.Maui.aar.Another approach is to update to the very latest AndroidX packages --
right now we are blocked on trying to get them all on the
dotnet-publicfeed. So we can take that approach later on.