-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement TitleColor property in PickerHandlers #602
Conversation
/// <summary> | ||
/// Gets the color for the Picker title. | ||
/// </summary> | ||
Color TitleColor { get; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be a Brush.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Totally agree. However, can we make it progressive? Start by merging this and other PRs related to Color, in order to complete Handlers and allow in Previews to work and port code in a simple way, and as we have to do with other important properties such as convert TextColor to Foreground, update little by little .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, we can do that.
3a04c7e
to
471c785
Compare
/// <summary> | ||
/// Gets the color for the Picker title. | ||
/// </summary> | ||
Color TitleColor { get; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, we can do that.
* Implement TitleColor property in PickerHandlers * Add PortHandler attributes * Updated Windows handler * Fix build errors * Removed unnecessary changes * Fix handler tests
Description of Change
Implement
TitleColor
property in PickerHandlers.Platforms Affected
PR Checklist