Properties moved to UseMauiCore need to work in the repo #6844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of #6767, I did not restart VS enough times so some changes did not apply in the IDE.
mattleibow
commented
May 5, 2022
| @@ -0,0 +1,10 @@ | |||
| <Project> | |||
|
|
|||
| <PropertyGroup Condition=" '$([MSBuild]::GetTargetPlatformIdentifier($(TargetFramework)))' == 'windows' "> | |||
There was a problem hiding this comment.
Moved the properties into this props file so that it can be shared by the workloads and the repo.
| @@ -1,4 +1,5 @@ | |||
| <Project> | |||
| <Import Project="$(_MauiBuildTasksLocation)AutoImport.InTree.props"/> | |||
| <Import Project="$(_MauiBuildTasksLocation)Microsoft.Maui.Core.props"/> | |||
There was a problem hiding this comment.
Make sure to include the props in the repo/samples.
| @@ -0,0 +1,3 @@ | |||
| <Project> | |||
There was a problem hiding this comment.
This targets file is just for completeness - and less effort later on.
| <GenerateLibraryLayout Condition=" '$(GenerateLibraryLayout)' == '' and '$(EnableMsixTooling)' == 'true' and '$(OutputType)' != 'Exe' and '$(OutputType)' != 'WinExe' ">true</GenerateLibraryLayout> | ||
| <WinUISDKReferences Condition=" '$(WinUISDKReferences)' == '' and '$(EnableMsixTooling)' == 'true' ">false</WinUISDKReferences> | ||
| </PropertyGroup> | ||
| <Import Project="Microsoft.Maui.Core.props" /> |
There was a problem hiding this comment.
Include the shared props file and not the actual setters.
mattleibow
changed the title
|
Confirmed still working in the maui release by copying over the targets and running some apps as well as building class libraries / apps with dotnet build. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
As part of #6767, I did not restart VS enough times so some changes did not apply in the IDE.
This PR makes sure the repo has access to the properties in the new file by including it in the InTree props/targets
Issues Fixed
Related to #6767