Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comment out measure all strategy on iOS 15 for grouping #6878

Merged
merged 1 commit into from
May 6, 2022
Merged

Comment out measure all strategy on iOS 15 for grouping #6878

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/Controls/src/Core/Handlers/Items/iOS/ItemsViewLayout.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,10 @@ public void PrepareCellForLayout(ItemsViewCell cell)

public override bool ShouldInvalidateLayout(UICollectionViewLayoutAttributes preferredAttributes, UICollectionViewLayoutAttributes originalAttributes)
{
// This is currently causing an infinite layout loop on iOS 15 https://github.com/dotnet/maui/issues/6566
if (preferredAttributes.RepresentedElementKind == "UICollectionElementKindSectionHeader" && OperatingSystem.IsIOSVersionAtLeast(15))
return base.ShouldInvalidateLayout(preferredAttributes, originalAttributes);

if (ItemSizingStrategy == ItemSizingStrategy.MeasureAllItems)
{
if (preferredAttributes.Bounds != originalAttributes.Bounds)
Expand Down