Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Completed event in EntryHandler #820

Merged
merged 8 commits into from
May 6, 2021
Merged

Implement Completed event in EntryHandler #820

merged 8 commits into from
May 6, 2021

Conversation

jsuarezruiz
Copy link
Contributor

Description of Change

Implement Completed event in EntryHandler.

Implemented in:

  • Android
  • iOS/macOS
  • Windows

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)
  • Adds the property to the appropriate interface
  • Avoids any changes not essential to the handler property
  • Adds the mapping to the PropertyMapper in the handler
  • Adds the mapping method to the Android, iOS, and Standard aspects of the handler
  • Implements the actual property updates (usually in extension methods in the Platform section of Core)
  • Tags ported renderer methods with [PortHandler]
  • Adds an example of the property to the sample project (MainPage)
  • Adds the property to the stub class
  • Implements basic property tests in DeviceTests

Does this PR touch anything that might effect accessibility?

No

rmarinho
rmarinho requested changes Apr 23, 2021
View reviewed changes
Copy link
Member

@rmarinho rmarinho left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iOS and Android work but failing on Windows

image

@jsuarezruiz
Copy link
Contributor Author

Could you review it again, please?

@jsuarezruiz jsuarezruiz merged commit ef573ce into main May 6, 2021
@jsuarezruiz jsuarezruiz deleted the entryhandler-completed branch May 6, 2021 07:22
rmarinho added a commit that referenced this pull request May 6, 2021
@jsuarezruiz @rmarinho
Implement Completed event in EntryHandler (#820)
3841bef 
* Implement Completed in WinUI

* Implement Completed on Android and iOS EntryHandlers

* Added TODO comment

* Updated EntryStub

* Enable nullable in Windows EntryHandler

* Updated Windows EntryHandler

Co-authored-by: Rui Marinho <me@ruimarinho.net>
@ghost ghost added the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label Jul 11, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 26, 2023
@Eilon Eilon removed the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label May 10, 2024
@samhouts samhouts added the fixed-in-6.0.100-preview.5 Look for this fix in 6.0.100-preview.5! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rmarinho rmarinho rmarinho approved these changes

Assignees
No one assigned
Labels
area-controls-entry Entry fixed-in-6.0.100-preview.5 Look for this fix in 6.0.100-preview.5! platform/android 🤖 platform/iOS 🍎 platform/windows 🪟
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jsuarezruiz @rmarinho @Eilon @samhouts