Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement HorizontalTextAlignment property in WinUI Picker #947

Merged
merged 4 commits into from
May 10, 2021

Conversation

jsuarezruiz
Copy link
Contributor

Description of Change

Implement HorizontalTextAlignment property in WinUI Picker.

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)
  • Adds the property to the appropriate interface
  • Avoids any changes not essential to the handler property
  • Adds the mapping to the PropertyMapper in the handler
  • Adds the mapping method to the Android, iOS, and Standard aspects of the handler
  • Implements the actual property updates (usually in extension methods in the Platform section of Core)
  • Tags ported renderer methods with [PortHandler]
  • Adds an example of the property to the sample project (MainPage)
  • Adds the property to the stub class
  • Implements basic property tests in DeviceTests

Does this PR touch anything that might effect accessibility?

No

@rmarinho rmarinho merged commit 1602444 into main May 10, 2021
@rmarinho rmarinho deleted the winui-picker-horizontalalignment branch May 10, 2021 18:42
@github-actions github-actions bot locked and limited conversation to collaborators Dec 22, 2023
@samhouts samhouts added the fixed-in-6.0.100-preview.5 Look for this fix in 6.0.100-preview.5! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
fixed-in-6.0.100-preview.5 Look for this fix in 6.0.100-preview.5! platform/windows 🪟
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants