Implement Visibility property in ViewHandlers #951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattleibow
reviewed
May 11, 2021
There was a problem hiding this comment.
Looks like it is good. Just wondering what is happening with regards to user interaction (hit test and tab stop) as well as accessibility. And then what should happen.
Android seems to have this feature, so does that work differently to when we set alpha to 0?
Comment on lines
+25
to
+26
| nativeView.Opacity = 0; | ||
| nativeView.Visibility = UI.Xaml.Visibility.Visible; |
There was a problem hiding this comment.
How does this work with tab stop, hit testing and screen readers?
There was a problem hiding this comment.
We don't know yet how they should work, so I think it's moot for now.
Comment on lines
31
to
32
| nativeView.Alpha = 0; | ||
| nativeView.Hidden = false; |
There was a problem hiding this comment.
How does this work with hit test and accessibility?
hartez
force-pushed
the
visibility-viewhandler
branch
from
8348156
to
14011d9
Compare
hartez
approved these changes
May 14, 2021
mattleibow
approved these changes
May 16, 2021
12 tasks
lytico
pushed a commit
to lytico/maui
that referenced
this pull request
May 20, 2021
* Implement IsVisible property in ViewHandlers * Fix the build error * Fix build error * Implement Visibility property * Updated Windows implementation * Actually trigger an update of the Visibility property with the handlers * Move bool->Visibility converter into Controls * Make new layouts Visibility-aware * Handle Visibility.Collapsed for iOS * Disambiguate MAUI Visibility and WinUI Visibility * Set up example * Fix rebase errors * Fix rebase errors * Fix xml comment * Remove double mapping * Reconcile ActivityIndicator Visibility with IsRunning property * Fix iOS Visibility tests Co-authored-by: E.Z. Hart <hartez@gmail.com> Co-authored-by: Matthew Leibowitz <mattleibow@live.com>
|
Did you give up on Visibility (Visible, Hidden, Collapsed) in favor of IsVisible? I can see the enum in the Object Browser, but it's not appearing on any controls yet. I hope I'm misinterpreting this thread incorrectly. Really need Visibility implemented. |
samhouts
added
area-controls-collectionview
samhouts
added
area-layout
Eilon
removed
the
legacy-area-controls
samhouts
added
the
fixed-in-6.0.100-preview.5
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Implement
Visibilityproperty in ViewHandlers.Related with #707
We need to review which approach fits better.
Platforms Affected
PR Checklist