-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Visibility property in ViewHandlers #951
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it is good. Just wondering what is happening with regards to user interaction (hit test and tab stop) as well as accessibility. And then what should happen.
Android seems to have this feature, so does that work differently to when we set alpha to 0?
nativeView.Opacity = 0; | ||
nativeView.Visibility = UI.Xaml.Visibility.Visible; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does this work with tab stop, hit testing and screen readers?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't know yet how they should work, so I think it's moot for now.
nativeView.Alpha = 0; | ||
nativeView.Hidden = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does this work with hit test and accessibility?
8348156
to
14011d9
Compare
* Implement IsVisible property in ViewHandlers * Fix the build error * Fix build error * Implement Visibility property * Updated Windows implementation * Actually trigger an update of the Visibility property with the handlers * Move bool->Visibility converter into Controls * Make new layouts Visibility-aware * Handle Visibility.Collapsed for iOS * Disambiguate MAUI Visibility and WinUI Visibility * Set up example * Fix rebase errors * Fix rebase errors * Fix xml comment * Remove double mapping * Reconcile ActivityIndicator Visibility with IsRunning property * Fix iOS Visibility tests Co-authored-by: E.Z. Hart <hartez@gmail.com> Co-authored-by: Matthew Leibowitz <mattleibow@live.com>
Did you give up on Visibility (Visible, Hidden, Collapsed) in favor of IsVisible? I can see the enum in the Object Browser, but it's not appearing on any controls yet. I hope I'm misinterpreting this thread incorrectly. Really need Visibility implemented. |
Description of Change
Implement
Visibility
property in ViewHandlers.Related with #707
We need to review which approach fits better.
Platforms Affected
PR Checklist