Removing unnecessary types

dotnet · Feb 20, 2024 · 9314121 · 9314121
1 parent 72749c4
commit 9314121
Show file tree

Hide file tree

Showing 6 changed files with 0 additions and 42 deletions.
diff --git a/src/Analyzers/API/BuildAnalyzerConfiguration.cs b/src/Analyzers/API/BuildAnalyzerConfiguration.cs
@@ -8,8 +8,6 @@ public class BuildAnalyzerConfiguration
     public static BuildAnalyzerConfiguration Default { get; } = new()
     {
         LifeTimeScope = Experimental.LifeTimeScope.PerProject,
-        SupportedInvocationConcurrency = InvocationConcurrency.Parallel,
-        PerformanceWeightClass = Experimental.PerformanceWeightClass.Normal,
         EvaluationAnalysisScope = Experimental.EvaluationAnalysisScope.AnalyzedProjectOnly,
         Severity = BuildAnalyzerResultSeverity.Info,
         IsEnabled = false,
@@ -18,8 +16,6 @@ public class BuildAnalyzerConfiguration
     public static BuildAnalyzerConfiguration Null { get; } = new();
 
     public LifeTimeScope? LifeTimeScope { get; internal init; }
-    public InvocationConcurrency? SupportedInvocationConcurrency { get; internal init; }
-    public PerformanceWeightClass? PerformanceWeightClass { get; internal init; }
     public EvaluationAnalysisScope? EvaluationAnalysisScope { get; internal init; }
     public BuildAnalyzerResultSeverity? Severity { get; internal init; }
     public bool? IsEnabled { get; internal init; }

diff --git a/src/Analyzers/API/InvocationConcurrency.cs b/src/Analyzers/API/InvocationConcurrency.cs
diff --git a/src/Analyzers/API/PerformanceWeightClass.cs b/src/Analyzers/API/PerformanceWeightClass.cs
diff --git a/src/Analyzers/Infrastructure/BuildAnalyzerConfigurationInternal.cs b/src/Analyzers/Infrastructure/BuildAnalyzerConfigurationInternal.cs
@@ -16,8 +16,6 @@ namespace Microsoft.Build.Analyzers.Infrastructure;
 internal sealed class BuildAnalyzerConfigurationInternal
 {
     public LifeTimeScope LifeTimeScope { get; internal init; }
-    public InvocationConcurrency SupportedInvocationConcurrency { get; internal init; }
-    public PerformanceWeightClass PerformanceWeightClass { get; internal init; }
     public EvaluationAnalysisScope EvaluationAnalysisScope { get; internal init; }
     public BuildAnalyzerResultSeverity Severity { get; internal init; }
     public bool IsEnabled { get; internal init; }

diff --git a/src/Analyzers/Infrastructure/ConfigurationProvider.cs b/src/Analyzers/Infrastructure/ConfigurationProvider.cs
@@ -85,11 +85,9 @@ public static BuildAnalyzerConfigurationInternal GetMergedConfiguration(BuildAna
 
         return new BuildAnalyzerConfigurationInternal()
         {
-            SupportedInvocationConcurrency = GetConfigValue(editorConfig, defaultConfig, cfg => cfg.SupportedInvocationConcurrency),
             EvaluationAnalysisScope = GetConfigValue(editorConfig, defaultConfig, cfg => cfg.EvaluationAnalysisScope),
             IsEnabled = GetConfigValue(editorConfig, defaultConfig, cfg => cfg.IsEnabled),
             LifeTimeScope = GetConfigValue(editorConfig, defaultConfig, cfg => cfg.LifeTimeScope),
-            PerformanceWeightClass = GetConfigValue(editorConfig, defaultConfig, cfg => cfg.PerformanceWeightClass),
             Severity = GetConfigValue(editorConfig, defaultConfig, cfg => cfg.Severity)
         };
 

diff --git a/src/Analyzers/OM/ParsedItemsContext.cs b/src/Analyzers/OM/ParsedItemsContext.cs
@@ -10,19 +10,9 @@
 using Microsoft.Build.Construction;
 
 namespace Microsoft.Build.Experimental;
-public enum ItemType
-{
-    ProjectReference,
-    PackageReference,
-    Compile,
-    EmbeddedResource
-}
 
 public static class ItemTypeExtensions
 {
-    public static IEnumerable<ProjectItemElement> GetItemsOfType(this IEnumerable<ProjectItemElement> items, ItemType itemType)
-        => GetItemsOfType(items, itemType.ToString());
-
     public static IEnumerable<ProjectItemElement> GetItemsOfType(this IEnumerable<ProjectItemElement> items,
         string itemType)
     {
@@ -36,9 +26,6 @@ public class ItemsHolder(IEnumerable<ProjectItemElement> items, IEnumerable<Proj
     public IEnumerable<ProjectItemElement> Items { get; } = items;
     public IEnumerable<ProjectItemGroupElement> ItemGroups { get; } = itemGroups;
 
-    public IEnumerable<ProjectItemElement> GetItemsOfType(ItemType itemType)
-        => Items.GetItemsOfType(itemType);
-
     public IEnumerable<ProjectItemElement> GetItemsOfType(string itemType)
     {
         return Items.GetItemsOfType(itemType);