Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use streamreader instead of string to load xml #1004

Merged
merged 11 commits into from
Oct 12, 2016
Merged

Use streamreader instead of string to load xml #1004

merged 11 commits into from
Oct 12, 2016

Commits on Sep 15, 2016

  1. Use streamreader instead of string to load xml

    @martinscholz83
    martinscholz83 committed Sep 15, 2016
    Configuration menu
    Copy the full SHA
    7790e70 View commit details
    Browse the repository at this point in the history

  2. add stream to using statement

    @martinscholz83
    martinscholz83 committed Sep 15, 2016
    Configuration menu
    Copy the full SHA
    305eb9a View commit details
    Browse the repository at this point in the history

  3. add streamreader to ProjectRootElementCache

    @martinscholz83
    martinscholz83 committed Sep 15, 2016
    Configuration menu
    Copy the full SHA
    f18df5c View commit details
    Browse the repository at this point in the history

  4. use XmlReader 

    Because we now read from a stream we should use XmlReader instead of
XmlTextReader and get encoding with `GetAttribute()`.
    @martinscholz83
    martinscholz83 committed Sep 15, 2016
    Configuration menu
    Copy the full SHA
    24fd7e3 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2016

  1. add DtdProcessing to XMLReader Constructor 

    In XMLReader `DtdProcessing` property is readonly and had to be set in
constructor
    @martinscholz83
    martinscholz83 committed Sep 16, 2016
    Configuration menu
    Copy the full SHA
    44aafc9 View commit details
    Browse the repository at this point in the history

  2. enable BOM for StreamReader 

    enable BOM for StreamReader and use this as default encoding instead of
`Default.Encoding`
    @martinscholz83
    martinscholz83 committed Sep 16, 2016
    Configuration menu
    Copy the full SHA
    28bc2fe View commit details
    Browse the repository at this point in the history

  3. change unit tests 

    change unit tests that they work with the new XMLReader
    @martinscholz83
    martinscholz83 committed Sep 16, 2016
    Configuration menu
    Copy the full SHA
    decd351 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2016

  1. Disable LargeElemntLocation tests 

    These tests were disabled because of same error like in dotnet#270
    @martinscholz83
    martinscholz83 committed Sep 19, 2016
    Configuration menu
    Copy the full SHA
    430a051 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'refs/remotes/Microsoft/master' into Use… 

    …-StreamReader-For-Load-XML
    @martinscholz83
    martinscholz83 committed Sep 19, 2016
    Configuration menu
    Copy the full SHA
    eed0ec4 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2016

  1. Revert "Disable LargeElemntLocation tests" 

    This reverts commit 430a051.
    @martinscholz83
    martinscholz83 committed Oct 12, 2016
    Configuration menu
    Copy the full SHA
    89abb08 View commit details
    Browse the repository at this point in the history

  2. Revert "change unit tests" 

    This reverts commit decd351.
    @martinscholz83
    martinscholz83 committed Oct 12, 2016
    Configuration menu
    Copy the full SHA
    7661ec6 View commit details
    Browse the repository at this point in the history